| Message ID | pull.1590.git.git.1697211227.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | branch.c: adjust error messages to coding guidelines | expand |
On 13-oct-2023 15:33:45, Isoken June Ibizugbe via GitGitGadget wrote: > As per the CodingGuidelines document, it is recommended that a single-line > message provided to error messages such as die(), error() and warning(), > should start with a lowercase letter and should not end with a period. > > Signed-off-by: Isoken June Ibizugbe isokenjune@gmail.com > > Isoken June Ibizugbe (2): > branch.c: ammend error messages for die() > branch.c: adjust error messages to coding guidelines I don't understand why two commits. Maybe it was unintentional and you want to merge all changes into one commit, using git rebase. > > builtin/branch.c | 66 ++++++++++++++++++++++++------------------------ > 1 file changed, 33 insertions(+), 33 deletions(-) You still need to adjust the tests. Take a look at: https://github.com/git/git/actions/runs/6509642887/job/17681596358
As per the CodingGuidelines document, it is recommended that a single-line message provided to error messages such as die(), error() and warning(), should start with a lowercase letter and should not end with a period. Signed-off-by: Isoken June Ibizugbe isokenjune@gmail.com Isoken June Ibizugbe (2): branch.c: ammend error messages for die() branch.c: adjust error messages to coding guidelines builtin/branch.c | 66 ++++++++++++++++++++++++------------------------ 1 file changed, 33 insertions(+), 33 deletions(-) base-commit: aab89be2eb6ca51eefeb8c8066f673f447058856 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1590%2FJunie06%2Famend-error-mesg-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1590/Junie06/amend-error-mesg-v1 Pull-Request: https://github.com/git/git/pull/1590