| Message ID | pull.1775.git.1724164270.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Update the win+VS build definition | expand |
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes: > These two patches have been in Git for Windows' fork for quite a while. > > While the win+VS builds are not run in Git's CI builds, it is still a good > idea to upstream these changes. > > Johannes Schindelin (2): > ci: bump microsoft/setup-msbuild from v1 to v2 > ci(win+VS): download the vcpkg artifacts using a dedicated GitHub > Action > > .github/workflows/main.yml | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) Thanks. Do you mind if I applied these directly to 'maint' and merged the result upwards?
Hi Junio, On Tue, 20 Aug 2024, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> > writes: > > > These two patches have been in Git for Windows' fork for quite a while. > > > > While the win+VS builds are not run in Git's CI builds, it is still a good > > idea to upstream these changes. > > > > Johannes Schindelin (2): > > ci: bump microsoft/setup-msbuild from v1 to v2 > > ci(win+VS): download the vcpkg artifacts using a dedicated GitHub > > Action > > > > .github/workflows/main.yml | 14 +++++--------- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > Thanks. > > Do you mind if I applied these directly to 'maint' and merged the > result upwards? I concur that this is a good idea. Thank you, Johannes
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: >> Do you mind if I applied these directly to 'maint' and merged the >> result upwards? > > I concur that this is a good idea. Will, do. Thanks.
These two patches have been in Git for Windows' fork for quite a while. While the win+VS builds are not run in Git's CI builds, it is still a good idea to upstream these changes. Johannes Schindelin (2): ci: bump microsoft/setup-msbuild from v1 to v2 ci(win+VS): download the vcpkg artifacts using a dedicated GitHub Action .github/workflows/main.yml | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) base-commit: bb9c16bd4f1a9a00799e10c81ee6506cf468c0c7 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1775%2Fdscho%2Fwin%2BVS-updates-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1775/dscho/win+VS-updates-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/1775