[0/2] meson: wire up contrib/credential

Message

Kazuhiro Kato via GitGitGadget Feb. 13, 2025, 6:37 p.m. UTC

It would be neat to also run test t0303-credential-external with
GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.

M Hickford (2):
  meson: wire up credential-wincred
  meson: wire up credential-libsecret

 contrib/credential/libsecret/meson.build            | 3 +++
 contrib/credential/meson.build                      | 6 ++++++
 contrib/credential/wincred/git-credential-wincred.c | 2 ++
 contrib/credential/wincred/meson.build              | 1 +
 contrib/meson.build                                 | 1 +
 meson_options.txt                                   | 4 ++++
 6 files changed, 17 insertions(+)
 create mode 100644 contrib/credential/libsecret/meson.build
 create mode 100644 contrib/credential/meson.build
 create mode 100644 contrib/credential/wincred/meson.build


base-commit: e2067b49ecaef9b7f51a17ce251f9207f72ef52d
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1859%2Fhickford%2Fmeson-credential-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1859/hickford/meson-credential-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1859

Comments

Patrick Steinhardt Feb. 14, 2025, 4:53 a.m. UTC | #1

On Thu, Feb 13, 2025 at 06:37:37PM +0000, M Hickford via GitGitGadget wrote:
> It would be neat to also run test t0303-credential-external with
> GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.

Thanks for working on this! I have a patch series sitting locally for a
while that wires up all credential helpers and more, as well. It also
wires up netrc and fixes its tests to allow out-of-tree testing, which
doesn't work right now. What I don't have though is the patch for the
wincred helper.

The patch series is currently still blocked on [1], which is why I have
been holding back on it. Would you mind if I picked your patch to fix
wincred, but we then wait with wiring up remaining credential helpers
until my follow-up patch series is unblocked?

Meanwhile, I'd appreciate any feedback on [1] to help move it forward,
if you have the time :)

Patrick

[1]: <[e-mail]>