mbox series

[0/1] commit-reach: fix first-parent heuristic

Message ID pull.51.git.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series commit-reach: fix first-parent heuristic | expand

Message

Linus Arver via GitGitGadget Oct. 18, 2018, 5:24 p.m. UTC 
I originally reported this fix [1] after playing around with the trace2
series for measuring performance. Since trace2 isn't merging quickly, I
pulled the performance fix patch out and am sending it on its own. The only
difference here is that we don't have the tracing to verify the performance
fix in the test script.

See the patch message for details about the fix.

Thanks, -Stolee

[1] 
https://public-inbox.org/git/20180906151309.66712-7-dstolee@microsoft.com/

[RFC PATCH 6/6] commit-reach: fix first-parent heuristic

Derrick Stolee (1):
  commit-reach: fix first-parent heuristic

 commit-reach.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: a4b8ab5363a32f283a61ef3a962853556d136c0e
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-51%2Fderrickstolee%2Ffirst-parent-heuristic-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-51/derrickstolee/first-parent-heuristic-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/51

Comments

Junio C Hamano Oct. 19, 2018, 2:31 a.m. UTC | #1 
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> I originally reported this fix [1] after playing around with the trace2
> series for measuring performance. Since trace2 isn't merging quickly, I
> pulled the performance fix patch out and am sending it on its own. The only
> difference here is that we don't have the tracing to verify the performance
> fix in the test script.

Thanks for sending this separately.  What's the current status of
the tracing patch series, by the way?
Jeff Hostetler Oct. 19, 2018, 7:40 p.m. UTC | #2 
On 10/18/2018 10:31 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> I originally reported this fix [1] after playing around with the trace2
>> series for measuring performance. Since trace2 isn't merging quickly, I
>> pulled the performance fix patch out and am sending it on its own. The only
>> difference here is that we don't have the tracing to verify the performance
>> fix in the test script.
> 
> Thanks for sending this separately.  What's the current status of
> the tracing patch series, by the way?
> 

I'm still working on it. I hope to reroll and submit a new version
next week.  We are currently dogfooding a version of it with our gvfs
users.

Jeff