mbox series

[v3,0/2] builtin/*: update usage format

Message ID pull.822.v3.git.1609944243.gitgitgadget@gmail.com (mailing list archive)
Headers show
Series builtin/*: update usage format | expand

Message

Koji Nakamaru via GitGitGadget Jan. 6, 2021, 2:44 p.m. UTC 
According to the "Error Messages" section of Documentation/CodingGuidelines,
we should not end in a full stop or start with a capital letter. Fix old
error and usage messages to match this expectation.

Signed-off-by: adl 1607364851@qq.com

Junio C Hamano (1):
  parse-options: format argh like error messages

ZheNing Hu (1):
  builtin/*: update usage format

 builtin/am.c                |  4 ++--
 builtin/blame.c             | 48 ++++++++++++++++++-------------------
 builtin/commit-graph.c      |  6 ++---
 builtin/fast-export.c       | 22 ++++++++---------
 builtin/log.c               |  8 +++----
 builtin/shortlog.c          | 10 ++++----
 builtin/submodule--helper.c | 24 +++++++++----------
 parse-options.h             |  6 ++---
 8 files changed, 64 insertions(+), 64 deletions(-)


base-commit: 6d3ef5b467eccd2769f1aa1c555d317d3c8dc707
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-822%2Fadlternative%2Fdev-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-822/adlternative/dev-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/822

Range-diff vs v2:

 2:  c5f01b0eab1 ! 1:  9d508df032b parse-options: format argh like error messages
     @@ Commit message
      
          Noticed-by: ZheNing Hu <adlternative@gmail.com>
          Signed-off-by: Junio C Hamano <gitster@pobox.com>
     +    Signed-off-by: ZheNing Hu <adlternative@gmail.com>
      
       ## parse-options.h ##
      @@ parse-options.h: typedef enum parse_opt_result parse_opt_ll_cb(struct parse_opt_ctx_t *ctx,
 1:  52f7c8457dd ! 2:  d3eb6dcff14 builtin/*: update usage format
     @@ Metadata
       ## Commit message ##
          builtin/*: update usage format
      
     -    According to the "Error Messages" section of
     -    Documentation/CodingGuidelines, we should not end in a full
     -    stop or start with a capital letter. Fix old error and usage
     +    According to the guidelines in parse-options.h,
     +    we should not end in a full stop or start with
     +    a capital letter. Fix old error and usage
          messages to match this expectation.
      
          Signed-off-by: ZheNing Hu <adlternative@gmail.com>

Comments

Junio C Hamano Jan. 6, 2021, 11:14 p.m. UTC | #1 
>  builtin/am.c                |  4 ++--
>  builtin/blame.c             | 48 ++++++++++++++++++-------------------
>  builtin/commit-graph.c      |  6 ++---
>  builtin/fast-export.c       | 22 ++++++++---------
>  builtin/log.c               |  8 +++----
>  builtin/shortlog.c          | 10 ++++----
>  builtin/submodule--helper.c | 24 +++++++++----------
>  parse-options.h             |  6 ++---
>  8 files changed, 64 insertions(+), 64 deletions(-)

Looks good to me.  Thanks.