| Message ID | pull.829.git.1609356413.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanups around index operations | expand |
On Wed, Dec 30, 2020 at 11:26 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote: > > I've taken a professional interest in the index lately, and I've been trying > mostly to learn about it and measure different operations. Along the way, > I've seen some possible improvements in documentation, behavior, and > tracing. > > This series collects most of my thoughts so far, including: > > 1. Adding extra trace2 regions and statistics (similar to [1]) (Patches > 1-5). > 2. Update documentation about the cached tree extension (Patches 6-7). > 3. Removing an unnecessary loop from verify_cache() (Patch 8). The series seems pretty simple and clean to me. As I mentioned on patch 6, though, I don't know much about the cache-tree extension myself (I show up in blame/log due to moving a function there with just some slight tweaks), so it'd be nice if someone who does can take a look at the documentation added in patch 6.
On 12/30/2020 3:19 PM, Elijah Newren wrote: > On Wed, Dec 30, 2020 at 11:26 AM Derrick Stolee via GitGitGadget > <gitgitgadget@gmail.com> wrote: >> >> I've taken a professional interest in the index lately, and I've been trying >> mostly to learn about it and measure different operations. Along the way, >> I've seen some possible improvements in documentation, behavior, and >> tracing. >> >> This series collects most of my thoughts so far, including: >> >> 1. Adding extra trace2 regions and statistics (similar to [1]) (Patches >> 1-5). >> 2. Update documentation about the cached tree extension (Patches 6-7). >> 3. Removing an unnecessary loop from verify_cache() (Patch 8). > > The series seems pretty simple and clean to me. As I mentioned on > patch 6, though, I don't know much about the cache-tree extension > myself (I show up in blame/log due to moving a function there with > just some slight tweaks), so it'd be nice if someone who does can take > a look at the documentation added in patch 6. Thanks for the quick review. And I've CC'd Junio since I forgot that GitGitGadget no longer auto-CCs him. Thanks, -Stolee
I've taken a professional interest in the index lately, and I've been trying mostly to learn about it and measure different operations. Along the way, I've seen some possible improvements in documentation, behavior, and tracing. This series collects most of my thoughts so far, including: 1. Adding extra trace2 regions and statistics (similar to [1]) (Patches 1-5). 2. Update documentation about the cached tree extension (Patches 6-7). 3. Removing an unnecessary loop from verify_cache() (Patch 8). Thanks, -Stolee [1] https://lore.kernel.org/git/pull.828.git.1609302714183.gitgitgadget@gmail.com/ Derrick Stolee (8): tree-walk: report recursion counts unpack-trees: add trace2 regions cache-tree: use trace2 in cache_tree_update() cache-tree: trace regions for I/O cache-tree: trace regions for prime_cache_tree index-format: update preamble to cached tree extension index-format: discuss recursion of cached-tree better cache-tree: avoid path comparison loop when silent Documentation/technical/index-format.txt | 39 +++++++++++++++++++----- cache-tree.c | 25 +++++++++++++-- tree-walk.c | 33 ++++++++++++++++++++ unpack-trees.c | 6 +++- 4 files changed, 92 insertions(+), 11 deletions(-) base-commit: 71ca53e8125e36efbda17293c50027d31681a41f Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-829%2Fderrickstolee%2Fcache-tree%2Fbasics-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-829/derrickstolee/cache-tree/basics-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/829