diff mbox series

[v3,2/4] doc: interpret-trailers: use input redirection

Message ID 12f7b10462184cbac884859e91d7b45e021041ee.1681326818.git.code@khaugsbakk.name (mailing list archive)
State Superseded
Headers show
Series doc: interpret-trailers: don't use deprecated config | expand

Commit Message

Kristoffer Haugsbakk April 12, 2023, 7:52 p.m. UTC
Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---

Notes (series):
    Link: https://lore.kernel.org/git/xmqqbkk44qbo.fsf@gitster.g/

 Documentation/git-interpret-trailers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Junio C Hamano April 12, 2023, 9:16 p.m. UTC | #1
Kristoffer Haugsbakk <code@khaugsbakk.name> writes:

> Suggested-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---

Perhaps explain why it is a good idea in the body of the message?

    Instead of "cat"ting a single file into a pipe, redirect from
    the file to the standard input of the command on the downstream
    side of the pipe.  This is more straight-forward, saves one
    extra process, and often makes the line shorter.

or something like that.
diff mbox series

Patch

diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt
index 15d34b983f..6b712564a4 100644
--- a/Documentation/git-interpret-trailers.txt
+++ b/Documentation/git-interpret-trailers.txt
@@ -280,7 +280,7 @@  $ cat msg.txt
 subject
 
 message
-$ cat msg.txt | git interpret-trailers --trailer 'sign: Alice <alice@example.com>' --trailer 'sign: Bob <bob@example.com>'
+$ git interpret-trailers --trailer 'sign: Alice <alice@example.com>' --trailer 'sign: Bob <bob@example.com>' <msg.txt
 subject
 
 message