| Message ID | 20180911234951.14129-4-sbeller@google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fetch: make sure submodule oids are fetched | expand |
Stefan Beller <sbeller@google.com> writes: > The submodule subsystem is really bad at staying within 80 characters. > Fix it while we are here. Makes sense. Thanks. > > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > submodule.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/submodule.c b/submodule.c > index a2b266fbfae..d29dfa3d1f5 100644 > --- a/submodule.c > +++ b/submodule.c > @@ -1244,7 +1244,8 @@ static int get_next_submodule(struct child_process *cp, > if (!submodule) { > const char *name = default_name_or_path(ce->name); > if (name) { > - default_submodule.path = default_submodule.name = name; > + default_submodule.path = name; > + default_submodule.name = name; > submodule = &default_submodule; > } > } > @@ -1254,8 +1255,10 @@ static int get_next_submodule(struct child_process *cp, > default: > case RECURSE_SUBMODULES_DEFAULT: > case RECURSE_SUBMODULES_ON_DEMAND: > - if (!submodule || !unsorted_string_list_lookup(&changed_submodule_names, > - submodule->name)) > + if (!submodule || > + !unsorted_string_list_lookup( > + &changed_submodule_names, > + submodule->name)) > continue; > default_argv = "on-demand"; > break;
diff --git a/submodule.c b/submodule.c index a2b266fbfae..d29dfa3d1f5 100644 --- a/submodule.c +++ b/submodule.c @@ -1244,7 +1244,8 @@ static int get_next_submodule(struct child_process *cp, if (!submodule) { const char *name = default_name_or_path(ce->name); if (name) { - default_submodule.path = default_submodule.name = name; + default_submodule.path = name; + default_submodule.name = name; submodule = &default_submodule; } } @@ -1254,8 +1255,10 @@ static int get_next_submodule(struct child_process *cp, default: case RECURSE_SUBMODULES_DEFAULT: case RECURSE_SUBMODULES_ON_DEMAND: - if (!submodule || !unsorted_string_list_lookup(&changed_submodule_names, - submodule->name)) + if (!submodule || + !unsorted_string_list_lookup( + &changed_submodule_names, + submodule->name)) continue; default_argv = "on-demand"; break;
The submodule subsystem is really bad at staying within 80 characters. Fix it while we are here. Signed-off-by: Stefan Beller <sbeller@google.com> --- submodule.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)