diff mbox series

[19/23] submodule: don't add submodule as odb for push

Message ID 20181114001306.138053-20-sbeller@google.com
State New, archived
Headers show
Series Bring more repository handles into our code base | expand

Commit Message

Stefan Beller Nov. 14, 2018, 12:13 a.m. UTC
In push_submodule(), because we do not actually need access to objects
in the submodule, do not invoke add_submodule_odb().
(for_each_remote_ref_submodule() does not require access to those
objects, and the actual push is done by spawning another process,
which handles object access by itself.)

This code of push_submodule() is exercised in t5531 and continues
to work, showing that the submodule odbc is not needed.

Signed-off-by: Stefan Beller <sbeller@google.com>
 submodule.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series


diff --git a/submodule.c b/submodule.c
index 262f03f118..5818088df2 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1021,9 +1021,6 @@  static int push_submodule(const char *path,
 			  const struct string_list *push_options,
 			  int dry_run)
-	if (add_submodule_odb(path))
-		return 1;
 	if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
 		struct child_process cp = CHILD_PROCESS_INIT;
 		argv_array_push(&cp.args, "push");