[19/23] submodule: don't add submodule as odb for push

Message ID	20181215000942.46033-20-sbeller@google.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> Date: Fri, 14 Dec 2018 16:09:38 -0800 In-Reply-To: <20181215000942.46033-1-sbeller@google.com> Message-Id: <20181215000942.46033-20-sbeller@google.com> Mime-Version: 1.0 References: <20181215000942.46033-1-sbeller@google.com> Subject: [PATCH 19/23] submodule: don't add submodule as odb for push From: Stefan Beller <sbeller@google.com> To: git@vger.kernel.org Cc: Stefan Beller <sbeller@google.com>, Junio C Hamano <gitster@pobox.com> Content-Type: text/plain; charset="UTF-8" Sender: git-owner@vger.kernel.org Precedence: bulk
Series	sb/more-repo-in-api \| expand [00/23] sb/more-repo-in-api [01/23] sha1_file: allow read_object to read objects in arbitrary repositories [02/23] packfile: allow has_packed_and_bad to handle arbitrary repositories [03/23] object-store: allow read_object_file_extended to read from any repo [04/23] object-store: prepare read_object_file to deal with any repo [05/23] object-store: prepare has_{sha1, object}_file to handle any repo [06/23] object: parse_object to honor its repository argument [07/23] commit: allow parse_commit* to handle any repo [08/23] commit-reach.c: allow paint_down_to_common to handle any repo [09/23] commit-reach.c: allow merge_bases_many to handle any repo [10/23] commit-reach.c: allow remove_redundant to handle any repo [11/23] commit-reach.c: allow get_merge_bases_many_0 to handle any repo [12/23] commit-reach: prepare get_merge_bases to handle any repo [13/23] commit-reach: prepare in_merge_bases[_many] to handle any repo [14/23] commit: prepare get_commit_buffer to handle any repo [15/23] commit: prepare repo_unuse_commit_buffer to handle any repo [16/23] commit: prepare logmsg_reencode to handle arbitrary repositories [17/23] pretty: prepare format_commit_message to handle arbitrary repositories [18/23] submodule: use submodule repos for object lookup [19/23] submodule: don't add submodule as odb for push [20/23] commit-graph: convert remaining functions to handle any repo [21/23] commit: prepare free_commit_buffer and release_commit_memory for any repo [22/23] path.h: make REPO_GIT_PATH_FUNC repository agnostic [23/23] t/helper/test-repository: celebrate independence from the_repository

Message ID

20181215000942.46033-20-sbeller@google.com (mailing list archive)

State

New, archived

Headers

Date: Fri, 14 Dec 2018 16:09:38 -0800
In-Reply-To: <20181215000942.46033-1-sbeller@google.com>
Message-Id: <20181215000942.46033-20-sbeller@google.com>
Mime-Version: 1.0
References: <20181215000942.46033-1-sbeller@google.com>
Subject: [PATCH 19/23] submodule: don't add submodule as odb for push
From: Stefan Beller <sbeller@google.com>
To: git@vger.kernel.org
Cc: Stefan Beller <sbeller@google.com>,
        Junio C Hamano <gitster@pobox.com>
Content-Type: text/plain; charset="UTF-8"
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

sb/more-repo-in-api | expand

Commit Message

Stefan Beller Dec. 15, 2018, 12:09 a.m. UTC

In push_submodule(), because we do not actually need access to objects
in the submodule, do not invoke add_submodule_odb().
(for_each_remote_ref_submodule() does not require access to those
objects, and the actual push is done by spawning another process,
which handles object access by itself.)

This code of push_submodule() is exercised in t5531 and continues
to work, showing that the submodule odbc is not needed.

Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 submodule.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/submodule.c b/submodule.c
index 4486ff664b..d9c06767a1 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1023,9 +1023,6 @@  static int push_submodule(const char *path,
 			  const struct string_list *push_options,
 			  int dry_run)
 {
-	if (add_submodule_odb(path))
-		return 1;
-
 	if (for_each_remote_ref_submodule(path, has_remote, NULL) > 0) {
 		struct child_process cp = CHILD_PROCESS_INIT;
 		argv_array_push(&cp.args, "push");

[19/23] submodule: don't add submodule as odb for push

Commit Message

Patch