| Message ID | 20190222105658.26831-1-avarab@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Makefile: remove an out-of-date comment | expand |
On Fri, Feb 22, 2019 at 11:56:58AM +0100, Ævar Arnfjörð Bjarmason wrote: > Remove a comment referring to a caveat that hasn't been applicable > since 18b0fc1ce1 ("Git.pm: Kill Git.xs for now", 2006-09-23). > > At the time of 8d7f586f13 ("Git.pm: Support for perl/ being built by a > different compiler", 2006-06-25) some of the code in perl would be > built by a C compiler, but support for that went away a few months > later in 18b0fc1ce1 discussed above. > > Since my 20d2a30f8f ("Makefile: replace perl/Makefile.PL with simple > make rules", 2017-12-10) the perl/ directory doesn't even have its own > build process. I liked that commit before, but seeing that it makes this hairy corner case go away, I like it even more. ;) The patch itself seems obviously correct. -Peff
diff --git a/Makefile b/Makefile index c5240942f2..97e922cc41 100644 --- a/Makefile +++ b/Makefile @@ -591,9 +591,6 @@ SPATCH_FLAGS = --all-includes --patch . ### --- END CONFIGURATION SECTION --- -# Those must not be GNU-specific; they are shared with perl/ which may -# be built by a different compiler. (Note that this is an artifact now -# but it still might be nice to keep that distinction.) BASIC_CFLAGS = -I. BASIC_LDFLAGS =
Remove a comment referring to a caveat that hasn't been applicable since 18b0fc1ce1 ("Git.pm: Kill Git.xs for now", 2006-09-23). At the time of 8d7f586f13 ("Git.pm: Support for perl/ being built by a different compiler", 2006-06-25) some of the code in perl would be built by a C compiler, but support for that went away a few months later in 18b0fc1ce1 discussed above. Since my 20d2a30f8f ("Makefile: replace perl/Makefile.PL with simple make rules", 2017-12-10) the perl/ directory doesn't even have its own build process. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Makefile | 3 --- 1 file changed, 3 deletions(-)