| Message ID | 20190222112757.20035-1-pclouds@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Delete check-racy.c | expand |
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes: > This is git-checy-racy command, added a long time ago [1] and was never > part of the default build. Naturally after some makefile changes [2], > git-check-racy was no longer recognized as a build target. Even if it > compiles to day, it will not link after the introduction of > common-main.c [3]. > > Racy index has not been a problem for a long time [4]. It's time to let > this code go. I briefly consider if check-racy should be part of > test-tool. But I don't think it's worth the effort. > > [1] 42f774063d (Add check program "git-check-racy" - 2006-08-15) > [2] c373991375 (Makefile: list generated object files in OBJECTS - > 2010-01-26) > [3] 3f2e2297b9 (add an extra level of indirection to main() - > 2016-07-01) > [4] I pretend I don't remember anything about the recent split-index's > racy problem > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> > --- > check-racy.c (gone) | 28 ---------------------------- > 1 file changed, 28 deletions(-) Nice.
diff --git a/check-racy.c b/check-racy.c deleted file mode 100644 index 24b6542352..0000000000 --- a/check-racy.c +++ /dev/null @@ -1,28 +0,0 @@ -#include "cache.h" - -int main(int ac, char **av) -{ - int i; - int dirty, clean, racy; - - dirty = clean = racy = 0; - read_cache(); - for (i = 0; i < active_nr; i++) { - struct cache_entry *ce = active_cache[i]; - struct stat st; - - if (lstat(ce->name, &st)) { - error_errno("lstat(%s)", ce->name); - continue; - } - - if (ce_match_stat(ce, &st, 0)) - dirty++; - else if (ce_match_stat(ce, &st, CE_MATCH_RACY_IS_DIRTY)) - racy++; - else - clean++; - } - printf("dirty %d, clean %d, racy %d\n", dirty, clean, racy); - return 0; -}
This is git-checy-racy command, added a long time ago [1] and was never part of the default build. Naturally after some makefile changes [2], git-check-racy was no longer recognized as a build target. Even if it compiles to day, it will not link after the introduction of common-main.c [3]. Racy index has not been a problem for a long time [4]. It's time to let this code go. I briefly consider if check-racy should be part of test-tool. But I don't think it's worth the effort. [1] 42f774063d (Add check program "git-check-racy" - 2006-08-15) [2] c373991375 (Makefile: list generated object files in OBJECTS - 2010-01-26) [3] 3f2e2297b9 (add an extra level of indirection to main() - 2016-07-01) [4] I pretend I don't remember anything about the recent split-index's racy problem Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- check-racy.c (gone) | 28 ---------------------------- 1 file changed, 28 deletions(-)