[v13,08/27] stash: rename test cases to be more descriptive

Message ID	20190225231631.30507-9-t.gummerer@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: Thomas Gummerer <t.gummerer@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Johannes Schindelin <Johannes.Schindelin@gmx.de>, Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>, =?utf-8?q?SZED?= =?utf-8?q?ER_G=C3=A1bor?= <szeder.dev@gmail.com>, Thomas Gummerer <t.gummerer@gmail.com> Subject: [PATCH v13 08/27] stash: rename test cases to be more descriptive Date: Mon, 25 Feb 2019 23:16:12 +0000 Message-Id: <20190225231631.30507-9-t.gummerer@gmail.com> In-Reply-To: <20190225231631.30507-1-t.gummerer@gmail.com> References: <nycvar.QRO.7.76.6.1902191127420.41@tvgsbejvaqbjf.bet> <20190225231631.30507-1-t.gummerer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Convert "git stash" to C builtin \| expand [v13,00/27] Convert "git stash" to C builtin [v13,01/27] sha1-name.c: add `get_oidf()` which acts like `get_oid()` [v13,02/27] strbuf.c: add `strbuf_join_argv()` [v13,03/27] strbuf.c: add `strbuf_insertf()` and `strbuf_vinsertf()` [v13,04/27] ident: add the ability to provide a "fallback identity" [v13,05/27] stash: improve option parsing test coverage [v13,06/27] t3903: modernize style [v13,07/27] t3903: add test for --intent-to-add file [v13,08/27] stash: rename test cases to be more descriptive [v13,09/27] stash: add tests for `git stash show` config [v13,10/27] stash: mention options in `show` synopsis [v13,11/27] stash: convert apply to builtin [v13,12/27] stash: convert drop and clear to builtin [v13,13/27] stash: convert branch to builtin [v13,14/27] stash: convert pop to builtin [v13,15/27] stash: convert list to builtin [v13,16/27] stash: convert show to builtin [v13,17/27] stash: convert store to builtin [v13,18/27] stash: convert create to builtin [v13,19/27] stash: convert push to builtin [v13,20/27] stash: make push -q quiet [v13,21/27] stash: convert save to builtin [v13,22/27] stash: optimize `get_untracked_files()` and `check_changes()` [v13,23/27] stash: replace all `write-tree` child processes with API calls [v13,24/27] stash: convert `stash--helper.c` into `stash.c` [v13,25/27] stash: add back the original, scripted `git stash` [v13,26/27] stash: optionally use the scripted version again [v13,27/27] tests: add a special setup where stash.useBuiltin is off

Message ID

20190225231631.30507-9-t.gummerer@gmail.com (mailing list archive)

State

New, archived

Headers

From: Thomas Gummerer <t.gummerer@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
 Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>, =?utf-8?q?SZED?=
	=?utf-8?q?ER_G=C3=A1bor?= <szeder.dev@gmail.com>,
 Thomas Gummerer <t.gummerer@gmail.com>
Subject: [PATCH v13 08/27] stash: rename test cases to be more descriptive
Date: Mon, 25 Feb 2019 23:16:12 +0000
Message-Id: <20190225231631.30507-9-t.gummerer@gmail.com>
In-Reply-To: <20190225231631.30507-1-t.gummerer@gmail.com>
References: <nycvar.QRO.7.76.6.1902191127420.41@tvgsbejvaqbjf.bet>
 <20190225231631.30507-1-t.gummerer@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Convert "git stash" to C builtin | expand

Commit Message

Thomas Gummerer Feb. 25, 2019, 11:16 p.m. UTC

From: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>

Rename some test cases' labels to be more descriptive and under 80
characters per line.

Signed-off-by: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
---
 t/t3903-stash.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index fc292f339f..023421a36c 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -612,7 +612,7 @@  test_expect_success 'stash show -p - no stashes on stack, stash-like argument' '
 	test_cmp expected actual
 '
 
-test_expect_success 'stash drop - fail early if specified stash is not a stash reference' '
+test_expect_success 'drop: fail early if specified stash is not a stash ref' '
 	git stash clear &&
 	test_when_finished "git reset --hard HEAD && git stash clear" &&
 	git reset --hard &&
@@ -626,7 +626,7 @@  test_expect_success 'stash drop - fail early if specified stash is not a stash r
 	git reset --hard HEAD
 '
 
-test_expect_success 'stash pop - fail early if specified stash is not a stash reference' '
+test_expect_success 'pop: fail early if specified stash is not a stash ref' '
 	git stash clear &&
 	test_when_finished "git reset --hard HEAD && git stash clear" &&
 	git reset --hard &&
@@ -690,7 +690,7 @@  test_expect_success 'invalid ref of the form "n", n >= N' '
 	git stash drop
 '
 
-test_expect_success 'stash branch should not drop the stash if the branch exists' '
+test_expect_success 'branch: do not drop the stash if the branch exists' '
 	git stash clear &&
 	echo foo >file &&
 	git add file &&
@@ -701,7 +701,7 @@  test_expect_success 'stash branch should not drop the stash if the branch exists
 	git rev-parse stash@{0} --
 '
 
-test_expect_success 'stash branch should not drop the stash if the apply fails' '
+test_expect_success 'branch: should not drop the stash if the apply fails' '
 	git stash clear &&
 	git reset HEAD~1 --hard &&
 	echo foo >file &&
@@ -715,7 +715,7 @@  test_expect_success 'stash branch should not drop the stash if the apply fails'
 	git rev-parse stash@{0} --
 '
 
-test_expect_success 'stash apply shows status same as git status (relative to current directory)' '
+test_expect_success 'apply: show same status as git status (relative to ./)' '
 	git stash clear &&
 	echo 1 >subdir/subfile1 &&
 	echo 2 >subdir/subfile2 &&
@@ -1056,7 +1056,7 @@  test_expect_success 'stash push -p with pathspec shows no changes only once' '
 	test_i18ncmp expect actual
 '
 
-test_expect_success 'stash push with pathspec shows no changes when there are none' '
+test_expect_success 'push <pathspec>: show no changes when there are none' '
 	>foo &&
 	git add foo &&
 	git commit -m "tmp" &&
@@ -1066,7 +1066,7 @@  test_expect_success 'stash push with pathspec shows no changes when there are no
 	test_i18ncmp expect actual
 '
 
-test_expect_success 'stash push with pathspec not in the repository errors out' '
+test_expect_success 'push: <pathspec> not in the repository errors out' '
 	>untracked &&
 	test_must_fail git stash push untracked &&
 	test_path_is_file untracked

[v13,08/27] stash: rename test cases to be more descriptive

Commit Message

Patch