diff mbox series

[v3,01/33] builtin rebase: use FREE_AND_NULL

Message ID	20190406113453.5149-2-pclouds@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?Tmd1eeG7hW4gVGjDoWkgTmfhu41jIER1eQ==?= <pclouds@gmail.com> To: pclouds@gmail.com Cc: git@vger.kernel.org, gitster@pobox.com, stefanbeller@gmail.com, szeder.dev@gmail.com, Johannes Schindelin <Johannes.Schindelin@gmx.de> Subject: [PATCH v3 01/33] builtin rebase: use FREE_AND_NULL Date: Sat, 6 Apr 2019 18:34:21 +0700 Message-Id: <20190406113453.5149-2-pclouds@gmail.com> In-Reply-To: <20190406113453.5149-1-pclouds@gmail.com> References: <20190403113457.20399-1-pclouds@gmail.com> <20190406113453.5149-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	nd/sha1-name-c-wo-the-repository updates \| expand [v3,00/33] nd/sha1-name-c-wo-the-repository updates [v3,01/33] builtin rebase: use FREE_AND_NULL [v3,02/33] builtin rebase: use oideq() [v3,03/33] packfile.c: add repo_approximate_object_count() [v3,04/33] refs.c: add refs_ref_exists() [v3,05/33] refs.c: add refs_shorten_unambiguous_ref() [v3,06/33] refs.c: remove the_repo from substitute_branch_name() [v3,07/33] refs.c: remove the_repo from expand_ref() [v3,08/33] refs.c: add repo_dwim_ref() [v3,09/33] refs.c: add repo_dwim_log() [v3,10/33] refs.c: remove the_repo from read_ref_at() [v3,11/33] commit.c: add repo_get_commit_tree() [v3,12/33] sha1-name.c: remove the_repo from sort_ambiguous() [v3,13/33] sha1-name.c: remove the_repo from find_abbrev_len_packed() [v3,14/33] sha1-name.c: add repo_find_unique_abbrev_r() [v3,15/33] sha1-name.c: store and use repo in struct disambiguate_state [v3,16/33] sha1-name.c: add repo_for_each_abbrev() [v3,17/33] sha1-name.c: remove the_repo from get_short_oid() [v3,18/33] sha1-name.c: remove the_repo from interpret_nth_prior_checkout() [v3,19/33] sha1-name.c: remove the_repo from interpret_branch_mark() [v3,20/33] sha1-name.c: add repo_interpret_branch_name() [v3,21/33] sha1-name.c: remove the_repo from get_oid_oneline() [v3,22/33] sha1-name.c: remove the_repo from get_describe_name() [v3,23/33] sha1-name.c: remove the_repo from get_oid_basic() [v3,24/33] sha1-name.c: remove the_repo from get_oid_1() [v3,25/33] sha1-name.c: remove the_repo from handle_one_ref() [v3,26/33] sha1-name.c: remove the_repo from diagnose_invalid_index_path() [v3,27/33] sha1-name.c: remove the_repo from resolve_relative_path() [v3,28/33] sha1-name.c: remove the_repo from get_oid_with_context_1() [v3,29/33] sha1-name.c: add repo_get_oid() [v3,30/33] submodule-config.c: use repo_get_oid for reading .gitmodules [v3,31/33] sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_name [v3,32/33] sha1-name.c: remove the_repo from other get_oid_* [v3,33/33] sha1-name.c: remove the_repo from get_oid_mb()

Commit Message

Duy Nguyen April 6, 2019, 11:34 a.m. UTC

From: SZEDER Gábor <szeder.dev@gmail.com>

Use the macro FREE_AND_NULL to release memory allocated for
'head_name' and clear its pointer.

Patch generated with 'contrib/coccinelle/free.cocci' and Coccinelle
v1.0.7 (previous Coccinelle versions don't notice this).

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/rebase.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/builtin/rebase.c b/builtin/rebase.c
index 77deebc65c..868bcd1446 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -1592,8 +1592,7 @@  int cmd_rebase(int argc, const char **argv, const char *prefix)
 				branch_name = options.head_name;
 
 		} else {
-			free(options.head_name);
-			options.head_name = NULL;
+			FREE_AND_NULL(options.head_name);
 			branch_name = "HEAD";
 		}
 		if (get_oid("HEAD", &options.orig_head))