| Message ID | 20190507223046.GA16315@sigill.intra.peff.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | t/lib-httpd: pass LSAN_OPTIONS through apache | expand |
On 2019.05.07 18:30, Jeff King wrote: > Just as we instruct Apache to pass through ASAN_OPTIONS (so that > server-side Git programs it spawns will respect our options while > running the tests), we should do the same with LSAN_OPTIONS. Otherwise > trying to collect a list of leaks like: > > export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan > make SANITIZE=leak test > > won't work for http tests (the server-side programs won't log their > leaks to the right place, and they'll prematurely die, producing a > spurious test failure). > > Signed-off-by: Jeff King <peff@peff.net> > --- > Found this after giving similar advice in > > https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/ > > t/lib-httpd/apache.conf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf > index 06a81b54c7..5c1c86c193 100644 > --- a/t/lib-httpd/apache.conf > +++ b/t/lib-httpd/apache.conf > @@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND > PassEnv GIT_VALGRIND_OPTIONS > PassEnv GNUPGHOME > PassEnv ASAN_OPTIONS > +PassEnv LSAN_OPTIONS > PassEnv GIT_TRACE > PassEnv GIT_CONFIG_NOSYSTEM > PassEnv GIT_TEST_SIDEBAND_ALL > -- > 2.21.0.1314.g224b191707 Looks good to me.
diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf index 06a81b54c7..5c1c86c193 100644 --- a/t/lib-httpd/apache.conf +++ b/t/lib-httpd/apache.conf @@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND PassEnv GIT_VALGRIND_OPTIONS PassEnv GNUPGHOME PassEnv ASAN_OPTIONS +PassEnv LSAN_OPTIONS PassEnv GIT_TRACE PassEnv GIT_CONFIG_NOSYSTEM PassEnv GIT_TEST_SIDEBAND_ALL
Just as we instruct Apache to pass through ASAN_OPTIONS (so that server-side Git programs it spawns will respect our options while running the tests), we should do the same with LSAN_OPTIONS. Otherwise trying to collect a list of leaks like: export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan make SANITIZE=leak test won't work for http tests (the server-side programs won't log their leaks to the right place, and they'll prematurely die, producing a spurious test failure). Signed-off-by: Jeff King <peff@peff.net> --- Found this after giving similar advice in https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/ t/lib-httpd/apache.conf | 1 + 1 file changed, 1 insertion(+)