[14/26] bisect: switch to using the_hash_algo

Message ID	20190818200427.870753-15-sandals@crustytoothpaste.net (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: "brian m. carlson" <sandals@crustytoothpaste.net> To: <git@vger.kernel.org> Cc: Taylor Blau <me@ttaylorr.com>, Derrick Stolee <dstolee@microsoft.com> Subject: [PATCH 14/26] bisect: switch to using the_hash_algo Date: Sun, 18 Aug 2019 20:04:15 +0000 Message-Id: <20190818200427.870753-15-sandals@crustytoothpaste.net> In-Reply-To: <20190818200427.870753-1-sandals@crustytoothpaste.net> References: <20190818200427.870753-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	object_id part 17 \| expand [00/26] object_id part 17 [01/26] builtin/replace: make hash size independent [02/26] patch-id: convert to use the_hash_algo [03/26] fetch-pack: use parse_oid_hex [04/26] builtin/receive-pack: switch to use the_hash_algo [05/26] builtin/blame: switch uses of GIT_SHA1_HEXSZ to the_hash_algo [06/26] builtin/rev-parse: switch to use the_hash_algo [07/26] blame: remove needless comparison with GIT_SHA1_HEXSZ [08/26] show-index: switch hard-coded constants to the_hash_algo [09/26] connected: switch GIT_SHA1_HEXSZ to the_hash_algo [10/26] bundle: switch to use the_hash_algo [11/26] combine-diff: replace GIT_SHA1_HEXSZ with the_hash_algo [12/26] config: use the_hash_algo in abbrev comparison [13/26] sha1-lookup: switch hard-coded constants to the_hash_algo [14/26] bisect: switch to using the_hash_algo [15/26] sequencer: convert to use the_hash_algo [16/26] pack-write: use hash_to_hex when writing checksums [17/26] builtin/repack: write object IDs of the proper length [18/26] builtin/worktree: switch null_sha1 to null_oid [19/26] cache: remove null_sha1 [20/26] wt-status: convert struct wt_status to object_id [21/26] packfile: replace sha1_to_hex [22/26] builtin/index-pack: replace sha1_to_hex [23/26] builtin/receive-pack: replace sha1_to_hex [24/26] rerere: replace sha1_to_hex [25/26] builtin/show-index: replace sha1_to_hex [26/26] midx: switch to using the_hash_algo

Message ID

20190818200427.870753-15-sandals@crustytoothpaste.net (mailing list archive)

State

New, archived

Headers

From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: <git@vger.kernel.org>
Cc: Taylor Blau <me@ttaylorr.com>,
        Derrick Stolee <dstolee@microsoft.com>
Subject: [PATCH 14/26] bisect: switch to using the_hash_algo
Date: Sun, 18 Aug 2019 20:04:15 +0000
Message-Id: <20190818200427.870753-15-sandals@crustytoothpaste.net>
In-Reply-To: <20190818200427.870753-1-sandals@crustytoothpaste.net>
References: <20190818200427.870753-1-sandals@crustytoothpaste.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

object_id part 17 | expand

Commit Message

brian m. carlson Aug. 18, 2019, 8:04 p.m. UTC

Instead of using GIT_SHA1_HEXSZ, use the_hash_algo so that the code is
hash size independent.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 bisect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bisect.c b/bisect.c
index e87ac29a51..e81c91d02c 100644
--- a/bisect.c
+++ b/bisect.c
@@ -707,7 +707,7 @@  static int bisect_checkout(const struct object_id *bisect_rev, int no_checkout)
 {
 	char bisect_rev_hex[GIT_MAX_HEXSZ + 1];
 
-	memcpy(bisect_rev_hex, oid_to_hex(bisect_rev), GIT_SHA1_HEXSZ + 1);
+	memcpy(bisect_rev_hex, oid_to_hex(bisect_rev), the_hash_algo->hexsz + 1);
 	update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0, UPDATE_REFS_DIE_ON_ERR);
 
 	argv_checkout[2] = bisect_rev_hex;

[14/26] bisect: switch to using the_hash_algo

Commit Message

Patch