[v2,4/4] Silence false-positive maybe-uninitialized warnings found by gcc 9 -flto

Commit Message

Stephan Beyer Sept. 5, 2019, 10:48 p.m. UTC

gcc 9.2.1 with -flto flag suspects some uninitialized variables which become
initialized in every code path where they are used.  These false positives
are "fixed" by this patch in the most naïve way.

This allows to compile git with gcc 9, link-time optimization, and using the
DEVELOPER=1 switch (which sets -Werror).

Signed-off-by: Stephan Beyer <[e-mail]>
---
 bulk-checkin.c | 2 ++
 fast-import.c  | 3 ++-
 2 files changed, 4 insertions(+), 1 deletion(-)

--
2.23.0.43.g31ebfd7ae6.dirty

Patch

diff --git a/bulk-checkin.c b/bulk-checkin.c
index 39ee7d6107..87fa28c227 100644
--- a/bulk-checkin.c
+++ b/bulk-checkin.c
@@ -200,6 +200,8 @@  static int deflate_to_pack(struct bulk_checkin_state *state,
 	struct hashfile_checkpoint checkpoint;
 	struct pack_idx_entry *idx = NULL;

+	checkpoint.offset = 0;
+
 	seekback = lseek(fd, 0, SEEK_CUR);
 	if (seekback == (off_t) -1)
 		return error("cannot find the current offset");
diff --git a/fast-import.c b/fast-import.c
index b44d6a467e..58f73f9105 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -903,7 +903,8 @@  static int store_object(
 	struct object_entry *e;
 	unsigned char hdr[96];
 	struct object_id oid;
-	unsigned long hdrlen, deltalen;
+	unsigned long hdrlen;
+	unsigned long deltalen = 0;
 	git_hash_ctx c;
 	git_zstream s;