diff mbox series

[v2,11/14] git-p4: use dict.items() iteration for python3 compatibility

Message ID 20191213235247.23660-13-yang.zhao@skyboxlabs.com (mailing list archive)
State New, archived
Headers show
Series [v2,01/14] git-p4: make python2.7 the oldest supported version | expand

Commit Message

Yang Zhao Dec. 13, 2019, 11:52 p.m. UTC
Python3 uses dict.items() instead of .iteritems() to provide
iteratoration over dict.  Although items() is technically less efficient
for python2.7 (allocates a new list instead of simply iterating), the
amount of data involved is very small and the penalty negligible.

Signed-off-by: Yang Zhao <yang.zhao@skyboxlabs.com>
Reviewed-by: Ben Keene <seraphire@gmail.com>
 git-p4.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/git-p4.py b/git-p4.py
index 7deee1b939..b7e31d4738 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1745,7 +1745,7 @@  def prepareSubmitTemplate(self, changelist=None):
         if not change_entry:
             die('Failed to decode output of p4 change -o')
-        for key, value in change_entry.iteritems():
+        for key, value in change_entry.items():
             if key.startswith('File'):
                 if 'depot-paths' in settings:
                     if not [p for p in settings['depot-paths']