| Message ID | 20200320130845.23257-2-harshitjain1371999@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | made the changes as per community suggestions | expand |
Hello Harshit, > The tests in t4131 leave a space character between the redirection operator > and the file i.e. the redirection target which does not conform to the > modern coding style. > Fix them. I think something like, The tests in t4131 were written a long time ago and hence contain style violations such as an extra space between the redirection operator(>) and the redirection target. Update it to match the latest CodingGuidelines. may be better. Also, when you deliver a newer version of the patch, i.e., version 2 in your case, you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and hence avoid confusion. If you are using 'git format-patch' to formulate your mails, you can do: 'git format-patch -v2 <..>' to get a v2 based mail. Regards, Shourya Shukla
Hi Shourya, On Fri, Mar 20, 2020 at 9:26 PM Shourya Shukla <shouryashukla.oo@gmail.com> wrote: > > Hello Harshit, > > > The tests in t4131 leave a space character between the redirection operator > > and the file i.e. the redirection target which does not conform to the > > modern coding style. > > > Fix them. > > I think something like, > > The tests in t4131 were written a long time ago and hence contain style violations > such as an extra space between the redirection operator(>) and the redirection target. > Update it to match the latest CodingGuidelines. > > may be better. > Please see the comment made by Junio Hamano, pasted below: "written a long time ago" does not have much value by itself (it does serve as a backstory to explain a half of why it does not use the more modern style, though). "have a few style violations." is almost meaningless (otherwise, you would not be doing a "modernize style" patch in the first place ;-). I myself also agree with the above comment and hence, wrote the commit message accordingly. What do you think? > Also, when you deliver a newer version of the patch, i.e., version 2 in your case, > you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and > hence avoid confusion. > > If you are using 'git format-patch' to formulate your mails, you can do: > > 'git format-patch -v2 <..>' to get a v2 based mail. > Oh nice, didn't know about this. I will keep this in mind for future patch submissions. Should I do this for the current patch as well? Regards, Harshit Jain
diff --git a/t/t4131-apply-fake-ancestor.sh b/t/t4131-apply-fake-ancestor.sh index b1361ce546..828d1a355b 100755 --- a/t/t4131-apply-fake-ancestor.sh +++ b/t/t4131-apply-fake-ancestor.sh @@ -17,8 +17,8 @@ test_expect_success 'setup' ' test_expect_success 'apply --build-fake-ancestor' ' git checkout 2 && - echo "A" > 1.t && - git diff > 1.patch && + echo "A" >1.t && + git diff >1.patch && git reset --hard && git checkout 1 && git apply --build-fake-ancestor 1.ancestor 1.patch @@ -26,8 +26,8 @@ test_expect_success 'apply --build-fake-ancestor' ' test_expect_success 'apply --build-fake-ancestor in a subdirectory' ' git checkout 3 && - echo "C" > sub/3.t && - git diff > 3.patch && + echo "C" >sub/3.t && + git diff >3.patch && git reset --hard && git checkout 4 && (
The tests in t4131 leave a space character between the redirection operator and the file i.e. the redirection target which does not conform to the modern coding style. Fix them. Signed-off-by: Harshit Jain <harshitjain1371999@gmail.com> --- t/t4131-apply-fake-ancestor.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)