From patchwork Mon Mar 30 14:04:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff King X-Patchwork-Id: 11465587 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9109B92A for ; Mon, 30 Mar 2020 14:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7043920776 for ; Mon, 30 Mar 2020 14:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727822AbgC3OEM (ORCPT ); Mon, 30 Mar 2020 10:04:12 -0400 Received: from cloud.peff.net ([104.130.231.41]:55640 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727191AbgC3OEM (ORCPT ); Mon, 30 Mar 2020 10:04:12 -0400 Received: (qmail 15186 invoked by uid 109); 30 Mar 2020 14:04:12 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 30 Mar 2020 14:04:12 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18778 invoked by uid 111); 30 Mar 2020 14:14:15 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 30 Mar 2020 10:14:15 -0400 Authentication-Results: peff.net; auth=none Date: Mon, 30 Mar 2020 10:04:11 -0400 From: Jeff King To: git@vger.kernel.org Subject: [PATCH 6/7] ref-filter: stop referring to "sha1 array" Message-ID: <20200330140411.GF2456038@coredump.intra.peff.net> References: <20200330140247.GA476088@coredump.intra.peff.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200330140247.GA476088@coredump.intra.peff.net> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org A comment refers to the "sha1s in the given sha1 array". But this became an oid_array along with everywhere else in 910650d2f8 (Rename sha1_array to oid_array, 2017-03-31). Plus there's an extra line of leftover editing cruft we can drop. Signed-off-by: Jeff King --- ref-filter.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index b1812cb69a..35776838f4 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1976,10 +1976,9 @@ static int for_each_fullref_in_pattern(struct ref_filter *filter, } /* - * Given a ref (sha1, refname), check if the ref belongs to the array - * of sha1s. If the given ref is a tag, check if the given tag points - * at one of the sha1s in the given sha1 array. - * the given sha1_array. + * Given a ref (oid, refname), check if the ref belongs to the array + * of oids. If the given ref is a tag, check if the given tag points + * at one of the oids in the given oid array. * NEEDSWORK: * 1. Only a single level of inderection is obtained, we might want to * change this to account for multiple levels (e.g. annotated tags