diff mbox series

[v4,1/4] gitfaq: files in .gitignore are tracked

Message ID 20200429093811.8475-1-shouryashukla.oo@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v4,1/4] gitfaq: files in .gitignore are tracked | expand

Commit Message

Shourya Shukla April 29, 2020, 9:38 a.m. UTC
Add issue in 'Common Issues' section which addresses the problem of
Git tracking files/paths mentioned in '.gitignore'.

Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
---
 Documentation/gitfaq.txt | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Elijah Newren April 29, 2020, 4:16 p.m. UTC | #1
On Wed, Apr 29, 2020 at 2:38 AM Shourya Shukla
<shouryashukla.oo@gmail.com> wrote:
>
> Add issue in 'Common Issues' section which addresses the problem of
> Git tracking files/paths mentioned in '.gitignore'.
>
> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
> ---
>  Documentation/gitfaq.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/gitfaq.txt b/Documentation/gitfaq.txt
> index 1cf83df118..b1e758ffd1 100644
> --- a/Documentation/gitfaq.txt
> +++ b/Documentation/gitfaq.txt
> @@ -223,6 +223,15 @@ a file checked into the repository which is a template or set of defaults which
>  can then be copied alongside and modified as appropriate.  This second, modified
>  file is usually ignored to prevent accidentally committing it.
>
> +[[files-in-.gitignore-are-tracked]]
> +I asked Git to ignore various files, yet they are still tracked::
> +       A `gitignore` file specifies intentionally untracked files
> +       that Git should ignore. Files already tracked by Git are
> +       not affected. See linkgit:gitignore[5] for details.
> +       To ignore and untrack the files appearing in the staging are
> +       it is advised to use `git rm --cached <file>`as well as make
> +       the file pattern is mentioned in the '.gitignore'.

Mostly looks good, but I can't help but nitpick several small items:
The first sentence alone seems to slightly undercut the answer, so
it'd be nice to make sure the first two sentences are just one.  Also,
it doesn't explain how people get into this state, which is probably
something users are curious about.  The "To ignore and untrack the
files" lists multiple end results, making it unclear which parts of
the end results the suggested steps are addressing.  There's also a
"staging are" typo (should be "staging area").

How about something like:

The purpose of gitignore files is to ensure that certain files not
tracked by Git remain untracked.  However, git allows people to
override the `gitignore` rules by using the --force option to `git
add`, and sometimes people started tracking a file unintentionally
before adding a pattern covering it to the gitignore rules.  If you
want to untrack a file, run `git rm --cached <file>` (and then
commit).  See linkgit:gitignore[5] for details.
Junio C Hamano April 29, 2020, 4:55 p.m. UTC | #2
Shourya Shukla <shouryashukla.oo@gmail.com> writes:

> Add issue in 'Common Issues' section which addresses the problem of
> Git tracking files/paths mentioned in '.gitignore'.
>
> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com>
> ---
>  Documentation/gitfaq.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/gitfaq.txt b/Documentation/gitfaq.txt
> index 1cf83df118..b1e758ffd1 100644
> --- a/Documentation/gitfaq.txt
> +++ b/Documentation/gitfaq.txt
> @@ -223,6 +223,15 @@ a file checked into the repository which is a template or set of defaults which
>  can then be copied alongside and modified as appropriate.  This second, modified
>  file is usually ignored to prevent accidentally committing it.
>  
> +[[files-in-.gitignore-are-tracked]]
> +I asked Git to ignore various files, yet they are still tracked::
> +	A `gitignore` file specifies intentionally untracked files
> +	that Git should ignore. Files already tracked by Git are
> +	not affected. See linkgit:gitignore[5] for details.
> +	To ignore and untrack the files appearing in the staging are
> +	it is advised to use `git rm --cached <file>`as well as make
> +	the file pattern is mentioned in the '.gitignore'.

After trimming down, it got a lot more readable.  The last sentence
is not quite, though, with riddled with typos.  Also the order of
untrack/ignore and steps to achieve these two things should match in
the description.

	To untrack and ignore files, use `git rm --cached <file>`
	and add a pattern to `.gitignore` that matches the <file>.

may be the minimum fix.

Thanks.
Shourya Shukla May 2, 2020, 6:36 a.m. UTC | #3
On 29/04 09:16, Elijah Newren wrote: 
> Mostly looks good, but I can't help but nitpick several small items:
> The first sentence alone seems to slightly undercut the answer, so
> it'd be nice to make sure the first two sentences are just one.  Also,
> it doesn't explain how people get into this state, which is probably
> something users are curious about.  The "To ignore and untrack the
> files" lists multiple end results, making it unclear which parts of
> the end results the suggested steps are addressing.  There's also a
> "staging are" typo (should be "staging area").
> 
> How about something like:
> 
> The purpose of gitignore files is to ensure that certain files not
> tracked by Git remain untracked.  However, git allows people to
> override the `gitignore` rules by using the --force option to `git
> add`, and sometimes people started tracking a file unintentionally
> before adding a pattern covering it to the gitignore rules.  If you
> want to untrack a file, run `git rm --cached <file>` (and then
> commit).  See linkgit:gitignore[5] for details.

This seems better, will improve. :)
diff mbox series

Patch

diff --git a/Documentation/gitfaq.txt b/Documentation/gitfaq.txt
index 1cf83df118..b1e758ffd1 100644
--- a/Documentation/gitfaq.txt
+++ b/Documentation/gitfaq.txt
@@ -223,6 +223,15 @@  a file checked into the repository which is a template or set of defaults which
 can then be copied alongside and modified as appropriate.  This second, modified
 file is usually ignored to prevent accidentally committing it.
 
+[[files-in-.gitignore-are-tracked]]
+I asked Git to ignore various files, yet they are still tracked::
+	A `gitignore` file specifies intentionally untracked files
+	that Git should ignore. Files already tracked by Git are
+	not affected. See linkgit:gitignore[5] for details.
+	To ignore and untrack the files appearing in the staging are
+	it is advised to use `git rm --cached <file>`as well as make
+	the file pattern is mentioned in the '.gitignore'.
+
 Hooks
 -----