git-bisect: remove no longer needed variables

Commit Message

Carlo Marcelo Arenas Belón May 21, 2020, 4:34 p.m. UTC

With the original functionality moved to bisect--helper there is no need
for them in git-bisect.sh anymore.

Signed-off-by: Carlo Marcelo Arenas Belón <[e-mail]>
---
 git-bisect.sh | 34 ----------------------------------
 1 file changed, 34 deletions(-)


base-commit: 011eca7cfdb7f13ee285c00dfe9ea576ec1166a7

Comments

Carlo Marcelo Arenas Belón May 21, 2020, 4:57 p.m. UTC | #1

On Thu, May 21, 2020 at 09:34:49AM -0700, Carlo Marcelo Arenas Belón wrote:
> With the original functionality moved to bisect--helper there is no need
> for them in git-bisect.sh anymore.

them, really only being _x40, which was retired with 06f5608c14
(bisect--helper: `bisect_start` shell function partially in C, 2019-01-02)

with the rest obviously still in use for `git bisect help` to anyone that
would bother trying to run the script before hitting `git send-email`; sorry
for the noise

Carlo

Patch

diff --git a/git-bisect.sh b/git-bisect.sh
index 2da0810b1a..d6debcbb87 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -1,41 +1,7 @@ 
 #!/bin/sh
 
-USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|view|replay|log|run]'
-LONG_USAGE='git bisect help
-	print this long help message.
-git bisect start [--term-{old,good}=<term> --term-{new,bad}=<term>]
-		 [--no-checkout] [<bad> [<good>...]] [--] [<pathspec>...]
-	reset bisect state and start bisection.
-git bisect (bad|new) [<rev>]
-	mark <rev> a known-bad revision/
-		a revision after change in a given property.
-git bisect (good|old) [<rev>...]
-	mark <rev>... known-good revisions/
-		revisions before change in a given property.
-git bisect terms [--term-good | --term-bad]
-	show the terms used for old and new commits (default: bad, good)
-git bisect skip [(<rev>|<range>)...]
-	mark <rev>... untestable revisions.
-git bisect next
-	find next bisection to test and check it out.
-git bisect reset [<commit>]
-	finish bisection search and go back to commit.
-git bisect (visualize|view)
-	show bisect status in gitk.
-git bisect replay <logfile>
-	replay bisection log.
-git bisect log
-	show bisect log.
-git bisect run <cmd>...
-	use <cmd>... to automatically bisect.
-
-Please use "git help bisect" to get the full man page.'
-
-OPTIONS_SPEC=
 . git-sh-setup
 
-_x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
-_x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
 TERM_BAD=bad
 TERM_GOOD=good