From patchwork Fri Aug 28 12:46:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Miriam R." X-Patchwork-Id: 11742725 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7D37C1575 for ; Fri, 28 Aug 2020 12:49:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64E1E2087D for ; Fri, 28 Aug 2020 12:49:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PCgiwDXQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729478AbgH1Mtr (ORCPT ); Fri, 28 Aug 2020 08:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729455AbgH1Mrg (ORCPT ); Fri, 28 Aug 2020 08:47:36 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C56EFC06123C for ; Fri, 28 Aug 2020 05:47:27 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id y3so1194096wrl.4 for ; Fri, 28 Aug 2020 05:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NXxMtopeJlIDy0Y/iz+K2ZtFarELYfjiV1J6/3GJVEU=; b=PCgiwDXQMm55pVzOQOwkoBhG7VU6kaL3hrGr47e3fpcDJI47aeHZ/ypNI0TzpxZzz6 nsS1yHKhjg+ovYTQ3dVs2vI/CS8/PfMxCOtl78y7LCPIps44Dg9d6DR1TxHq5mKmp1C3 SewS9BO+PuDFbC0MGyRsm858+H3HI8THzolHAl1X8YsWPLBLIY6pcWFJTkuw/vIHTsTE Ta0iyGlTCjiJjxhyqruSmeLLtX91TcaEwChOYj+DcSJSmlScZseiqljY3qles/GqjKeS 6+GGKq0MpMmySxdNCKnb0J+JBqy/Q8WS6TCV8k2TgGJnxXkNUV3/Vo1FTquPNZoEY7bX sx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NXxMtopeJlIDy0Y/iz+K2ZtFarELYfjiV1J6/3GJVEU=; b=TQGGWb01ZIjlkW4YMOVsSEAIYjO94wjhA4KNqiPd1ZOwfnjnZ9QkA8dvd3X/UjrMJS kL9w/oGoUynVhwZgr828OH8Dr85kmQhe/rRwKpCTITSVY23TkBy5wppV+7vjWj3IRFwd SKQdjrAdRt7oLr4rtsVBqiEvpi5kl7SD7ElqtseQz80P/aMLKcM7bWib3RjBuVAeik4e 7Zd9mRecDXGE789KMslcHDramRp9S9ijHePnJaXG3FffB0wTDFXAloYTWju5leJw+t1C udo4VdODdtnUHV7WXcSN9VUK9t295HXheiagWyTX/NV5ELx+amgLp7NXfWssv8FAFEti +z8Q== X-Gm-Message-State: AOAM532Cm+BuaTOj3Iy8s5/RCGmrTzhBMZpTa5XnGpxxX5+CWXwMSS1J 5gozOYXheOEw6eGDfmgqs3EUSOgUOrQ= X-Google-Smtp-Source: ABdhPJyIytkUUM0wzn/u24jlHwcaZ8Cu3xMwL2KkM95KJyDK8KoiK6fBpqX9sg7uztzIctpWaqjJpQ== X-Received: by 2002:a5d:56c1:: with SMTP id m1mr1322330wrw.87.1598618846065; Fri, 28 Aug 2020 05:47:26 -0700 (PDT) Received: from localhost.localdomain ([178.237.236.228]) by smtp.gmail.com with ESMTPSA id o66sm2176878wmb.27.2020.08.28.05.47.25 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Aug 2020 05:47:25 -0700 (PDT) From: Miriam Rubio To: git@vger.kernel.org Cc: Pranit Bauva , Lars Schneider , Christian Couder , Johannes Schindelin , Tanushree Tumane , Miriam Rubio Subject: [PATCH v6 13/13] bisect--helper: retire `--bisect-autostart` subcommand Date: Fri, 28 Aug 2020 14:46:17 +0200 Message-Id: <20200828124617.60618-14-mirucam@gmail.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200828124617.60618-1-mirucam@gmail.com> References: <20200828124617.60618-1-mirucam@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Pranit Bauva The `--bisect-autostart` subcommand is no longer used from the git-bisect.sh shell script. Instead the function `bisect_autostart()` is directly called from the C implementation. Mentored-by: Lars Schneider Mentored-by: Christian Couder Mentored-by: Johannes Schindelin Signed-off-by: Pranit Bauva Signed-off-by: Tanushree Tumane Signed-off-by: Miriam Rubio --- builtin/bisect--helper.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index a6282d54a2..be1291f036 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -29,7 +29,6 @@ static const char * const git_bisect_helper_usage[] = { " [--no-checkout] [--first-parent] [ [...]] [--] [...]"), N_("git bisect--helper --bisect-next"), N_("git bisect--helper --bisect-auto-next"), - N_("git bisect--helper --bisect-autostart"), N_("git bisect--helper --bisect-state (bad|new) []"), N_("git bisect--helper --bisect-state (good|old) [...]"), NULL @@ -919,7 +918,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) BISECT_START, BISECT_NEXT, BISECT_AUTO_NEXT, - BISECT_AUTOSTART, BISECT_STATE } cmdmode = 0; int res = 0, nolog = 0; @@ -940,8 +938,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) N_("find the next bisection commit"), BISECT_NEXT), OPT_CMDMODE(0, "bisect-auto-next", &cmdmode, N_("verify the next bisection state then checkout the next bisection commit"), BISECT_AUTO_NEXT), - OPT_CMDMODE(0, "bisect-autostart", &cmdmode, - N_("start the bisection if it has not yet been started"), BISECT_AUTOSTART), OPT_CMDMODE(0, "bisect-state", &cmdmode, N_("mark the state of ref (or refs)"), BISECT_STATE), OPT_BOOL(0, "no-log", &nolog, @@ -1001,12 +997,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) get_terms(&terms); res = bisect_auto_next(&terms, prefix); break; - case BISECT_AUTOSTART: - if (argc) - return error(_("--bisect-autostart does not accept arguments")); - set_terms(&terms, "bad", "good"); - res = bisect_autostart(&terms); - break; case BISECT_STATE: set_terms(&terms, "bad", "good"); get_terms(&terms);