diff mbox series

Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Message ID 20200829153920.17155-1-vvavrychuk@gmail.com (mailing list archive)
State New, archived
Headers show
Series Documentation/git-send-email.txt: Mention less secure app access might need to enable. | expand

Commit Message

Vasyl Vavrychuk Aug. 29, 2020, 3:39 p.m. UTC
Looks like Google changed Gmail security and now less secure app access
needs to be explicitly enabled if 2-factor authentication is not in
place, otherwise send-mail fails with:

  5.7.8 Username and Password not accepted. Learn more at
  5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
---
 Documentation/git-send-email.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Junio C Hamano Aug. 29, 2020, 6:33 p.m. UTC | #1
Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:

> Looks like Google changed Gmail security and now less secure app access
> needs to be explicitly enabled if 2-factor authentication is not in
> place, otherwise send-mail fails with:

'send-email' I presume?

>   5.7.8 Username and Password not accepted. Learn more at
>   5.7.8  https://support.google.com/mail/?p=BadCredentials v5sm13756502ede.13 - gsmtp

Is the v5sm1375... part stay constant that everybody would get the
same thing?

Otherwise,

    ... otherwise send-email fails with an error message from Gmail
    server telling the user to "Learn more" at 
    https://support.google.com/mail/?p=BadCredentials

would be preferrable.

> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> ---
>  Documentation/git-send-email.txt | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 0a69810147..06953fd1e0 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -494,7 +494,11 @@ edit ~/.gitconfig to specify your account settings:
>  	smtpServerPort = 587
>  ----
>  
> -If you have multifactor authentication setup on your gmail account, you will
> +If you do not have multi-factor authentication set up on your Gmail account, you
> +will need to allow less secure app access. Visit
> +https://myaccount.google.com/lesssecureapps to enable it.
> +
> +If you have multi-factor authentication set up on your Gmail account, you will
>  need to generate an app-specific password for use with 'git send-email'. Visit
>  https://security.google.com/settings/security/apppasswords to create it.

In 2020, we should probably list the instruction for those with 2
factor first and then give "less secure app access" as a fallback.
IOW, I'd suggest the order of these two paragraphs swapped.

Thanks.
Junio C Hamano Aug. 29, 2020, 7:29 p.m. UTC | #2
Junio C Hamano <gitster@pobox.com> writes:

> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:

Another thing I forgot to say.

Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.

Especially with grammofix s/to enable/to be enabled/ applied, the
above is way too long as a title and would stand out like a sore
thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output.
Something like

Subject: [PATCH] send-email doc: mention less secure app access with GMail

perhaps.

Thanks.
Junio C Hamano Sept. 6, 2020, 9:52 p.m. UTC | #3
Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
>
> Another thing I forgot to say.
>
> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.
>
> Especially with grammofix s/to enable/to be enabled/ applied, the
> above is way too long as a title and would stand out like a sore
> thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output.
> Something like
>
> Subject: [PATCH] send-email doc: mention less secure app access with GMail
>
> perhaps.
>
> Thanks.

Anything new on this topic?  No rush, but I'd hate to see a
basically good topic to be left in the stalled state too long.
Junio C Hamano Dec. 22, 2020, 7:58 p.m. UTC | #4
Junio C Hamano <gitster@pobox.com> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Vasyl Vavrychuk <vvavrychuk@gmail.com> writes:
>>
>> Another thing I forgot to say.
>>
>> Subject: [PATCH] Documentation/git-send-email.txt: Mention less secure app access might need to enable.
>>
>> Especially with grammofix s/to enable/to be enabled/ applied, the
>> above is way too long as a title and would stand out like a sore
>> thumb in "git shortlog --no-merges v2.28.0..v2.29.0" output.
>> Something like
>>
>> Subject: [PATCH] send-email doc: mention less secure app access with GMail
>>
>> perhaps.
>>
>> Thanks.
>
> Anything new on this topic?  No rush, but I'd hate to see a
> basically good topic to be left in the stalled state too long.

Just pinging old threads that we have been expecting a reroll, but
it has been more than 3 months.  Has an update been sent that I
missed?

Thanks.
diff mbox series

Patch

diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
index 0a69810147..06953fd1e0 100644
--- a/Documentation/git-send-email.txt
+++ b/Documentation/git-send-email.txt
@@ -494,7 +494,11 @@  edit ~/.gitconfig to specify your account settings:
 	smtpServerPort = 587
 ----
 
-If you have multifactor authentication setup on your gmail account, you will
+If you do not have multi-factor authentication set up on your Gmail account, you
+will need to allow less secure app access. Visit
+https://myaccount.google.com/lesssecureapps to enable it.
+
+If you have multi-factor authentication set up on your Gmail account, you will
 need to generate an app-specific password for use with 'git send-email'. Visit
 https://security.google.com/settings/security/apppasswords to create it.