diff mbox series

[v3] blame.c: replace instance of !oidcmp for oideq

Message ID 20200909131550.826462-1-eantoranz@gmail.com
State Accepted
Commit 1302badd16ad36bc9441367b240e053130d15f7a
Headers show
Series [v3] blame.c: replace instance of !oidcmp for oideq | expand

Commit Message

Edmundo Carmona Antoranz Sept. 9, 2020, 1:15 p.m. UTC
0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
introduced a call to oidcmp() that should be replaced with oideq()
defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

Signed-off-by: Edmundo Carmona Antoranz <eantoranz@gmail.com>
---
 blame.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Derrick Stolee Sept. 9, 2020, 6:33 p.m. UTC | #1
On 9/9/2020 9:15 AM, Edmundo Carmona Antoranz wrote:
> 0906ac2b (blame: use changed-path Bloom filters, 2020-04-16)
> introduced a call to oidcmp() that should be replaced with oideq()
> defined in 14438c4 (introduce hasheq() and oideq(), 2018-08-28)

LGTM. Thanks.

-Stolee
diff mbox series

Patch

diff --git a/blame.c b/blame.c
index da7e28800e..a8abe86ae4 100644
--- a/blame.c
+++ b/blame.c
@@ -1352,8 +1352,8 @@  static struct blame_origin *find_origin(struct repository *r,
 	else {
 		int compute_diff = 1;
 		if (origin->commit->parents &&
-		    !oidcmp(&parent->object.oid,
-			    &origin->commit->parents->item->object.oid))
+		    oideq(&parent->object.oid,
+			  &origin->commit->parents->item->object.oid))
 			compute_diff = maybe_changed_path(r, origin, bd);
 
 		if (compute_diff)