diff mbox series

[01/10] convert: drop unused crlf_action from check_global_conv_flags_eol()

Message ID 20200930122753.GA1901279@coredump.intra.peff.net (mailing list archive)
State Accepted
Commit 185e86522678fed077d6cec02381bcf899bf24e5
Headers show
Series dropping more unused parameters | expand

Commit Message

Jeff King Sept. 30, 2020, 12:27 p.m. UTC
The crlf_action parameter hasn't been used since a0ad53c181 (convert:
Correct NNO tests and missing `LF will be replaced by CRLF`,
2016-08-13), where that part of the function was hoisted out to a
separate will_convert_lf_to_crlf() helper. Let's drop the useless

Signed-off-by: Jeff King <peff@peff.net>
 convert.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/convert.c b/convert.c
index 8e6c292421..ee360c2f07 100644
--- a/convert.c
+++ b/convert.c
@@ -195,7 +195,7 @@  static enum eol output_eol(enum crlf_action crlf_action)
 	return core_eol;
-static void check_global_conv_flags_eol(const char *path, enum crlf_action crlf_action,
+static void check_global_conv_flags_eol(const char *path,
 			    struct text_stat *old_stats, struct text_stat *new_stats,
 			    int conv_flags)
@@ -547,7 +547,7 @@  static int crlf_to_git(const struct index_state *istate,
 			new_stats.crlf += new_stats.lonelf;
 			new_stats.lonelf = 0;
-		check_global_conv_flags_eol(path, crlf_action, &stats, &new_stats, conv_flags);
+		check_global_conv_flags_eol(path, &stats, &new_stats, conv_flags);
 	if (!convert_crlf_into_lf)
 		return 0;