diff mbox series

[08/10] test-advise: check argument count with argc instead of argv

Message ID 20200930123027.GH1901279@coredump.intra.peff.net (mailing list archive)
State Accepted
Commit 26e28fe7bbdf8b22ed096dfd76a9311e86ffb200
Headers show
Series dropping more unused parameters | expand

Commit Message

Jeff King Sept. 30, 2020, 12:30 p.m. UTC
We complain if "test-tool advise" is not given an argument, but we
quietly ignore any additional arguments it receives. Let's instead check
that we got the expected number. As a bonus, this silences
-Wunused-parameter, which notes that we don't ever look at argc.

While we're here, we can also fix the indentation in the conditional.

Signed-off-by: Jeff King <peff@peff.net>
 t/helper/test-advise.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/t/helper/test-advise.c b/t/helper/test-advise.c
index 38cdc2884e..a7043df1d3 100644
--- a/t/helper/test-advise.c
+++ b/t/helper/test-advise.c
@@ -5,8 +5,8 @@ 
 int cmd__advise_if_enabled(int argc, const char **argv)
-	if (!argv[1])
-	die("usage: %s <advice>", argv[0]);
+	if (argc != 2)
+		die("usage: %s <advice>", argv[0]);
 	git_config(git_default_config, NULL);