[v3,19/29] completion: zsh: simplify file_direct

Message ID	20201028020712.442623-20-felipe.contreras@gmail.com (mailing list archive)
State	Accepted
Commit	5d64fb20511270ffb2d939210a5afe66419f69ab
Headers	show Return-Path: <SRS0=U/aV=EE=vger.kernel.org=git-owner@kernel.org> From: Felipe Contreras <felipe.contreras@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, =?utf-8?q?SZEDER_G=C3=A1bor?= <szeder.dev@gmail.com>, Felipe Contreras <felipe.contreras@gmail.com> Subject: [PATCH v3 19/29] completion: zsh: simplify file_direct Date: Tue, 27 Oct 2020 20:07:02 -0600 Message-Id: <20201028020712.442623-20-felipe.contreras@gmail.com> In-Reply-To: <20201028020712.442623-1-felipe.contreras@gmail.com> References: <20201028020712.442623-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[v3,01/29] completion: zsh: fix __gitcomp_direct() \| expand [v3,01/29] completion: zsh: fix __gitcomp_direct() [v3,02/29] completion: zsh: fix name due to broken autoloading [v3,03/29] completion: zsh: fix bash script extension [v3,04/29] completion: zsh: reorganize install instructions [v3,05/29] completion: zsh: fix for directories with spaces [v3,06/29] completion: zsh: update slave script locations [v3,07/29] completion: prompt: fix color for Zsh [v3,08/29] completion: zsh: fix for command aliasing [v3,09/29] completion: bash: synchronize zsh wrapper [v3,10/29] completion: bash: remove zsh wrapper [v3,11/29] completion: zsh: fix completion for --no-.. options [v3,12/29] completion: fix conflict with bashcomp [v3,13/29] completion: zsh: add missing direct_append [v3,14/29] completion: zsh: fix splitting of words [v3,15/29] completion: zsh: simplify compadd functions [v3,16/29] completion: zsh: simplify direct compadd [v3,17/29] completion: zsh: trivial cleanup [v3,18/29] completion: zsh: simplify nl_append [v3,19/29] completion: zsh: simplify file_direct [v3,20/29] completion: zsh: shuffle functions around [v3,21/29] completion: zsh: refactor command completion [v3,22/29] completion: zsh: improve command tags [v3,23/29] completion: zsh: add alias descriptions [v3,24/29] completion: zsh: trivial simplification [v3,25/29] completion: zsh: add simple version check [v3,26/29] completion: bash: trivial cleanup [v3,27/29] completion: bash: cleanup cygwin check [v3,28/29] completion: bash: remove old compat wrappers [v3,29/29] Update copyright notices

Message ID

20201028020712.442623-20-felipe.contreras@gmail.com (mailing list archive)

State

Accepted

Commit

5d64fb20511270ffb2d939210a5afe66419f69ab

Headers

From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
 =?utf-8?q?SZEDER_G=C3=A1bor?= <szeder.dev@gmail.com>,
 Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v3 19/29] completion: zsh: simplify file_direct
Date: Tue, 27 Oct 2020 20:07:02 -0600
Message-Id: <20201028020712.442623-20-felipe.contreras@gmail.com>
In-Reply-To: <20201028020712.442623-1-felipe.contreras@gmail.com>
References: <20201028020712.442623-1-felipe.contreras@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

[v3,01/29] completion: zsh: fix __gitcomp_direct() | expand

Commit Message

Felipe Contreras Oct. 28, 2020, 2:07 a.m. UTC

It's exactly the same as __gitcomp_file() with no prefix.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.zsh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 7126c75001..4834ebc889 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -124,9 +124,7 @@  __gitcomp_nl_append ()
 
 __gitcomp_file_direct ()
 {
-	emulate -L zsh
-
-	compadd -f -- ${(f)1} && _ret=0
+	__gitcomp_file "$1" ''
 }
 
 __gitcomp_file ()

[v3,19/29] completion: zsh: simplify file_direct

Commit Message

Patch