diff mbox series

git-gui: ssh-askpass: add a checkbox to show the input text

Message ID 20201107222039.13900-1-davvid@gmail.com (mailing list archive)
State Accepted
Commit a4e1bc99713355b8b11cdd8ae691aa05f063b351
Headers show
Series git-gui: ssh-askpass: add a checkbox to show the input text | expand

Commit Message

David Aguilar Nov. 7, 2020, 10:20 p.m. UTC 
Hide the input text by default since the field is
commonly used for sensative informations such as passwords.

Add a "Show input" checkbox to conditionally show the input.

Helped-by: Miguel Boekhold <miguel.boekhold@osudio.com>
Signed-off-by: Efimov Vasily <laer.18@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
 git-gui--askpass | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

This patch gathers the submissions from the following sources:

https://github.com/patthoyts/git-gui/issues/22
https://github.com/prati0100/git-gui/pull/38
https://github.com/git-cola/git-cola/issues/1004
https://github.com/git-cola/git-cola/pull/1069

Comments

Pratyush Yadav Dec. 1, 2020, 7:41 p.m. UTC | #1 
On 07/11/20 02:20PM, David Aguilar wrote:
> Hide the input text by default since the field is
> commonly used for sensative informations such as passwords.
> 
> Add a "Show input" checkbox to conditionally show the input.
> 
> Helped-by: Miguel Boekhold <miguel.boekhold@osudio.com>
> Signed-off-by: Efimov Vasily <laer.18@gmail.com>
> Signed-off-by: David Aguilar <davvid@gmail.com>

Merged to git-gui/master. Thanks.
diff mbox series

Patch

diff --git a/git-gui--askpass b/git-gui--askpass
index 1c99ee8..71a536d 100755
--- a/git-gui--askpass
+++ b/git-gui--askpass
@@ -26,8 +26,21 @@  pack .m -side top -fill x -padx 20 -pady 20 -expand 1
 entry .e -textvariable answer -width 50
 pack .e -side top -fill x -padx 10 -pady 10
 
+proc on_show_input_changed {args} {
+	global show_input
+	if {$show_input} {
+		.e configure -show ""
+	} else {
+		.e configure -show "*"
+	}
+}
+trace add variable show_input write "on_show_input_changed"
+
+set show_input 0
+
 if {!$yesno} {
-	.e configure -show "*"
+	checkbutton .cb_show -text "Show input" -variable show_input
+	pack .cb_show -side top -anchor nw
 }
 
 frame .b