diff mbox series

[v3,2/4] completion: bash: improve function detection

Message ID 20201230232950.582152-3-felipe.contreras@gmail.com (mailing list archive)
State Accepted
Commit 810df0ea8ed00f31d372f3fd90c205d953aea1e6
Headers show
Series completion: make __git_complete public | expand

Commit Message

Felipe Contreras Dec. 30, 2020, 11:29 p.m. UTC 
1. We should quote the argument
 2. We don't need two redirections
 3. A safeguard for arguments (-a) would be good

Suggested-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/completion/git-completion.bash | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 869c73ee2c..1150d4bf44 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -3359,7 +3359,7 @@  __git_support_parseopt_helper () {
 }
 
 __git_have_func () {
-	declare -f $1 >/dev/null 2>/dev/null
+	declare -f -- "$1" >/dev/null 2>&1
 }
 
 __git_complete_command () {