| Message ID | 20210116171500.20092-1-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e3db0fe96f0a7bad44b23e07309f168ed13a5249 |
| Headers | show |
| Series | fsck doc: remove ancient out-of-date diagnostics | expand |
On Sat, Jan 16, 2021 at 06:15:00PM +0100, Ævar Arnfjörð Bjarmason wrote: > Remove diagnostics that haven't been emitted by "fsck" or its > predecessors for around 15 years. This documentation was added in > c64b9b88605 (Reference documentation for the core git commands., > 2005-05-05), but was out-of-date quickly after that. > > Notes on individual diagnostics: > > - "expect dangling commits": Added in bcee6fd8e71 (Make 'fsck' able > to[...], 2005-04-13), documented in c64b9b88605. Not emitted since > 1024932f019 (fsck-cache: walk the 'refs' directory[...], > 2005-05-18). > > - "missing sha1 directory": Added in 20222118ae4 (Add first cut at > "fsck-cache"[...], 2005-04-08), documented in c64b9b88605. Not > emitted since 230f13225df (Create object subdirectories on demand, > 2005-10-08). Thanks for digging on both of these. I checked independently and came to the same conclusion that you did, so I agree that these can be safely removed. Reviewed-by: Taylor Blau <me@ttaylorr.com> Thanks, Taylor
Taylor Blau <me@ttaylorr.com> writes: > On Sat, Jan 16, 2021 at 06:15:00PM +0100, Ævar Arnfjörð Bjarmason wrote: >> Remove diagnostics that haven't been emitted by "fsck" or its >> predecessors for around 15 years. This documentation was added in >> c64b9b88605 (Reference documentation for the core git commands., >> 2005-05-05), but was out-of-date quickly after that. >> >> Notes on individual diagnostics: >> >> - "expect dangling commits": Added in bcee6fd8e71 (Make 'fsck' able >> to[...], 2005-04-13), documented in c64b9b88605. Not emitted since >> 1024932f019 (fsck-cache: walk the 'refs' directory[...], >> 2005-05-18). >> >> - "missing sha1 directory": Added in 20222118ae4 (Add first cut at >> "fsck-cache"[...], 2005-04-08), documented in c64b9b88605. Not >> emitted since 230f13225df (Create object subdirectories on demand, >> 2005-10-08). > > Thanks for digging on both of these. I checked independently and came to > the same conclusion that you did, so I agree that these can be safely > removed. > > Reviewed-by: Taylor Blau <me@ttaylorr.com> > > Thanks, > Taylor Thanks, both.
diff --git a/Documentation/git-fsck.txt b/Documentation/git-fsck.txt index d72d15be5b..bd596619c0 100644 --- a/Documentation/git-fsck.txt +++ b/Documentation/git-fsck.txt @@ -129,14 +129,6 @@ using 'git commit-graph verify'. See linkgit:git-commit-graph[1]. Extracted Diagnostics --------------------- -expect dangling commits - potential heads - due to lack of head information:: - You haven't specified any nodes as heads so it won't be - possible to differentiate between un-parented commits and - root nodes. - -missing sha1 directory '<dir>':: - The directory holding the sha1 objects is missing. - unreachable <type> <object>:: The <type> object <object>, isn't actually referred to directly or indirectly in any of the trees or commits seen. This can
Remove diagnostics that haven't been emitted by "fsck" or its predecessors for around 15 years. This documentation was added in c64b9b88605 (Reference documentation for the core git commands., 2005-05-05), but was out-of-date quickly after that. Notes on individual diagnostics: - "expect dangling commits": Added in bcee6fd8e71 (Make 'fsck' able to[...], 2005-04-13), documented in c64b9b88605. Not emitted since 1024932f019 (fsck-cache: walk the 'refs' directory[...], 2005-05-18). - "missing sha1 directory": Added in 20222118ae4 (Add first cut at "fsck-cache"[...], 2005-04-08), documented in c64b9b88605. Not emitted since 230f13225df (Create object subdirectories on demand, 2005-10-08). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Documentation/git-fsck.txt | 8 -------- 1 file changed, 8 deletions(-)