diff mbox series

[v3,2/2] http: drop the check for an empty proxy password before approving

Message ID 20210312024027.33418-3-john@szakmeister.net (mailing list archive)
State Accepted
Commit a4a4439fdf2fa5867b3f30040be535cff65b8a42
Headers show
Series http: store credential when PKI auth is used | expand

Commit Message

John Szakmeister March 12, 2021, 2:40 a.m. UTC
credential_approve() already checks for a non-empty password before
saving, so there's no need to do the extra check here.

Signed-off-by: John Szakmeister <john@szakmeister.net>
---
 http.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/http.c b/http.c
index 60d01c6e83..3aeabf0947 100644
--- a/http.c
+++ b/http.c
@@ -1635,8 +1635,7 @@  static int handle_curl_result(struct slot_results *results)
 
 	if (results->curl_result == CURLE_OK) {
 		credential_approve(&http_auth);
-		if (proxy_auth.password)
-			credential_approve(&proxy_auth);
+		credential_approve(&proxy_auth);
 		credential_approve(&cert_auth);
 		return HTTP_OK;
 	} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {