diff mbox series

doc: update advice about other implementations' v4 index support

Message ID 20210409202206.29990-1-scottworley@scottworley.com (mailing list archive)
State New
Headers show
Series doc: update advice about other implementations' v4 index support | expand

Commit Message

scottworley@scottworley.com April 9, 2021, 8:22 p.m. UTC
From: Scott Worley <scottworley@scottworley.com>

Signed-off-by: Scott Worley <scottworley@scottworley.com>
---
 Documentation/git-update-index.txt | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Junio C Hamano April 9, 2021, 10:45 p.m. UTC | #1
scottworley@scottworley.com writes:

> From: Scott Worley <scottworley@scottworley.com>
>
> Signed-off-by: Scott Worley <scottworley@scottworley.com>
> ---
>  Documentation/git-update-index.txt | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
> index 2853f168d9..e8eca5dadf 100644
> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -166,9 +166,10 @@ you will need to handle the situation manually.
>  +
>  Version 4 performs a simple pathname compression that reduces index
>  size by 30%-50% on large repositories, which results in faster load
> -time. Version 4 is relatively young (first released in 1.8.0 in
> -October 2012). Other Git implementations such as JGit and libgit2
> -may not support it yet.
> +time. Version 4 is relatively young (first released in git 1.8.0 in
> +October 2012, supported in libgit2 0.24.4 from December 2016, go-git
> +4.0.0 from January 2018, and jgit 5.9.0 from September 2020). Other
> +Git implementations such as Dulwich may not support it yet.

Thanks for these dates.  Time flies---I didn't realize it has been
almost 9 years---the feature was merged in May 2012, in v1.7.11
(yes, I am hinting that the original lists a wrong date and we
should correct it while at it).

I wonder if we should lose "relatively young" from the description
here, though.
Derrick Stolee April 10, 2021, 1:12 a.m. UTC | #2
On 4/9/2021 6:45 PM, Junio C Hamano wrote:
> scottworley@scottworley.com writes:
> 
>> From: Scott Worley <scottworley@scottworley.com>
>>
>> Signed-off-by: Scott Worley <scottworley@scottworley.com>
>> ---
>>  Documentation/git-update-index.txt | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
>> index 2853f168d9..e8eca5dadf 100644
>> --- a/Documentation/git-update-index.txt
>> +++ b/Documentation/git-update-index.txt
>> @@ -166,9 +166,10 @@ you will need to handle the situation manually.
>>  +
>>  Version 4 performs a simple pathname compression that reduces index
>>  size by 30%-50% on large repositories, which results in faster load
>> -time. Version 4 is relatively young (first released in 1.8.0 in
>> -October 2012). Other Git implementations such as JGit and libgit2
>> -may not support it yet.
>> +time. Version 4 is relatively young (first released in git 1.8.0 in
>> +October 2012, supported in libgit2 0.24.4 from December 2016, go-git
>> +4.0.0 from January 2018, and jgit 5.9.0 from September 2020). Other
>> +Git implementations such as Dulwich may not support it yet.
> 
> Thanks for these dates.  Time flies---I didn't realize it has been
> almost 9 years---the feature was merged in May 2012, in v1.7.11
> (yes, I am hinting that the original lists a wrong date and we
> should correct it while at it).
> 
> I wonder if we should lose "relatively young" from the description
> here, though.
 
I was thinking the same thing. It has had extensions added such as
the End-of-index extension, but even that is approaching three years
ago.

Thanks,
-Stolee
diff mbox series

Patch

diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
index 2853f168d9..e8eca5dadf 100644
--- a/Documentation/git-update-index.txt
+++ b/Documentation/git-update-index.txt
@@ -166,9 +166,10 @@  you will need to handle the situation manually.
 +
 Version 4 performs a simple pathname compression that reduces index
 size by 30%-50% on large repositories, which results in faster load
-time. Version 4 is relatively young (first released in 1.8.0 in
-October 2012). Other Git implementations such as JGit and libgit2
-may not support it yet.
+time. Version 4 is relatively young (first released in git 1.8.0 in
+October 2012, supported in libgit2 0.24.4 from December 2016, go-git
+4.0.0 from January 2018, and jgit 5.9.0 from September 2020). Other
+Git implementations such as Dulwich may not support it yet.
 
 -z::
 	Only meaningful with `--stdin` or `--index-info`; paths are