| Message ID | 20210416191939.1120651-1-ville.skytta@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 76655e8a28d35c7243fa8f138c90a123aa32357f |
| Headers | show |
| Series | completion: avoid aliased command lookup error in nounset mode | expand |
Ville Skyttä <ville.skytta@iki.fi> writes: > Aliased command lookup accesses the `list` variable before it has been > set, causing an error in "nounset" mode. Initialize to an empty string > to avoid that. > > $ git nonexistent-command <Tab>bash: list: unbound variable > > Signed-off-by: Ville Skyttä <ville.skytta@iki.fi> > --- > contrib/completion/git-completion.bash | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, will queue. > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index dfa735ea62..49e76e9d08 100644 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -1129,7 +1129,7 @@ __git_pretty_aliases () > # __git_aliased_command requires 1 argument > __git_aliased_command () > { > - local cur=$1 last list word cmdline > + local cur=$1 last list= word cmdline > > while [[ -n "$cur" ]]; do > if [[ "$list" == *" $cur "* ]]; then
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index dfa735ea62..49e76e9d08 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1129,7 +1129,7 @@ __git_pretty_aliases () # __git_aliased_command requires 1 argument __git_aliased_command () { - local cur=$1 last list word cmdline + local cur=$1 last list= word cmdline while [[ -n "$cur" ]]; do if [[ "$list" == *" $cur "* ]]; then
Aliased command lookup accesses the `list` variable before it has been set, causing an error in "nounset" mode. Initialize to an empty string to avoid that. $ git nonexistent-command <Tab>bash: list: unbound variable Signed-off-by: Ville Skyttä <ville.skytta@iki.fi> --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)