[v2,6/9] git-svn: stop passing "-m" to "git rev-list"

Message ID	20210519114552.4180-7-sorganov@gmail.com (mailing list archive)
State	Accepted
Commit	23f6d40dd3e7aad72c7706bb75f77a6c73b69b56
Headers	show Return-Path: <git-owner@kernel.org> From: Sergey Organov <sorganov@gmail.com> To: Junio C Hamano <gitster@pobox.com> Cc: Jeff King <peff@peff.net>, Philip Oakley <philipoakley@iee.email>, Elijah Newren <newren@gmail.com>, Felipe Contreras <felipe.contreras@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmo=?= =?utf-8?b?w7Zyw7AgQmphcm1hc29u?= <avarab@gmail.com>, Alex Henrie <alexhenrie24@gmail.com>, git@vger.kernel.org, Sergey Organov <sorganov@gmail.com> Subject: [PATCH v2 6/9] git-svn: stop passing "-m" to "git rev-list" Date: Wed, 19 May 2021 14:45:49 +0300 Message-Id: <20210519114552.4180-7-sorganov@gmail.com> In-Reply-To: <20210519114552.4180-1-sorganov@gmail.com> References: <CAMMLpeR-W35Qq6a343ifrxJ=mwBc_VcXZtVrBYDpJTySNBroFw@mail.gmail.com> <20210519114552.4180-1-sorganov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	diff-merges: let -m imply -p \| expand [v2,0/9] diff-merges: let -m imply -p [v2,1/9] t4013: test that "-m" alone has no effect in "git log" [v2,2/9] t4013: test "git log -m --raw" [v2,3/9] t4013: test "git log -m --stat" [v2,4/9] t4013: test "git diff-index -m" [v2,5/9] diff-merges: move specific diff-index "-m" handling to diff-index [v2,6/9] git-svn: stop passing "-m" to "git rev-list" [v2,7/9] stash list: stop passing "-m" to "git log" [v2,8/9] diff-merges: rename "combined_imply_patch" to "merges_imply_patch" [v2,9/9] diff-merges: let "-m" imply "-p"

Message ID

20210519114552.4180-7-sorganov@gmail.com (mailing list archive)

State

Accepted

Commit

23f6d40dd3e7aad72c7706bb75f77a6c73b69b56

Headers

From: Sergey Organov <sorganov@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Philip Oakley <philipoakley@iee.email>,
 Elijah Newren <newren@gmail.com>,
 Felipe Contreras <felipe.contreras@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmo=?=
	=?utf-8?b?w7Zyw7AgQmphcm1hc29u?=  <avarab@gmail.com>,
 Alex Henrie <alexhenrie24@gmail.com>, git@vger.kernel.org,
 Sergey Organov <sorganov@gmail.com>
Subject: [PATCH v2 6/9] git-svn: stop passing "-m" to "git rev-list"
Date: Wed, 19 May 2021 14:45:49 +0300
Message-Id: <20210519114552.4180-7-sorganov@gmail.com>
In-Reply-To: <20210519114552.4180-1-sorganov@gmail.com>
References: 
 <CAMMLpeR-W35Qq6a343ifrxJ=mwBc_VcXZtVrBYDpJTySNBroFw@mail.gmail.com>
 <20210519114552.4180-1-sorganov@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

diff-merges: let -m imply -p | expand

Commit Message

Sergey Organov May 19, 2021, 11:45 a.m. UTC

rev-list doesn't utilize -m. It happens to eat it silently, so this
bug went unnoticed.

Signed-off-by: Sergey Organov <sorganov@gmail.com>
---
 perl/Git/SVN.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index f6f1dc03c608..35ff5a68963d 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
@@ -1636,7 +1636,7 @@  sub has_no_changes {
 	my $commit = shift;
 
 	my @revs = split / /, command_oneline(
-		qw(rev-list --parents -1 -m), $commit);
+		qw(rev-list --parents -1), $commit);
 
 	# Commits with no parents, e.g. the start of a partial branch,
 	# have changes by definition.

[v2,6/9] git-svn: stop passing "-m" to "git rev-list"

Commit Message

Patch