diff mbox series

help: fix small typo in error message

Message ID 20210520074214.40903-1-jn.avila@free.fr (mailing list archive)
State Accepted
Commit f22e938f3eee39a6492dcb5fc80e95e6a4889b59
Headers show
Series help: fix small typo in error message | expand

Commit Message

Jean-Noël AVILA May 20, 2021, 7:42 a.m. UTC
Classic string concatenation while forgetting a space character.

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---
 list-objects-filter-options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Nieder May 20, 2021, 9:36 p.m. UTC | #1
(cc: pks)
Jean-Noël Avila wrote:

> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
[...]
> -			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> +			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
>  					      "not a valid object type"), v0);

Good catch!

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.
Junio C Hamano May 20, 2021, 10:53 p.m. UTC | #2
Jean-Noël Avila <jn.avila@free.fr> writes:

> Classic string concatenation while forgetting a space character.
>
> Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
> ---
>  list-objects-filter-options.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.  This is a new message added in this round, so let's
fast-track this fix down.



> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> index 96a605c8ad..fd8d59f653 100644
> --- a/list-objects-filter-options.c
> +++ b/list-objects-filter-options.c
> @@ -102,7 +102,7 @@ static int gently_parse_list_objects_filter(
>  	} else if (skip_prefix(arg, "object:type=", &v0)) {
>  		int type = type_from_string_gently(v0, strlen(v0), 1);
>  		if (type < 0) {
> -			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
> +			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
>  					      "not a valid object type"), v0);
>  			return 1;
>  		}
diff mbox series

Patch

diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
index 96a605c8ad..fd8d59f653 100644
--- a/list-objects-filter-options.c
+++ b/list-objects-filter-options.c
@@ -102,7 +102,7 @@  static int gently_parse_list_objects_filter(
 	} else if (skip_prefix(arg, "object:type=", &v0)) {
 		int type = type_from_string_gently(v0, strlen(v0), 1);
 		if (type < 0) {
-			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is"
+			strbuf_addf(errbuf, _("'%s' for 'object:type=<type>' is "
 					      "not a valid object type"), v0);
 			return 1;
 		}