diff mbox series

[resend] graph: improve grammar of "invalid color" error message

Message ID 20210612184144.6894-1-alexhenrie24@gmail.com (mailing list archive)
State Accepted
Commit 98538307876ab9565c24d45bce6b5302f99fec0b
Headers show
Series [resend] graph: improve grammar of "invalid color" error message | expand

Commit Message

Alex Henrie June 12, 2021, 6:41 p.m. UTC
Without the "d", it sounds like a command, not an error, and is liable
to be translated incorrectly.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
Resending to make sure that this patch isn't forgotten.
---
 graph.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bagas Sanjaya June 13, 2021, 2:21 a.m. UTC | #1
Hi,

On 13/06/21 01.41, Alex Henrie wrote:
> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
> 

s/liable/prone/

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.
> ---
>   graph.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
>   		if (!color_parse_mem(start, comma - start, color))
>   			strvec_push(colors, color);
>   		else
> -			warning(_("ignore invalid color '%.*s' in log.graphColors"),
> +			warning(_("ignored invalid color '%.*s' in log.graphColors"),
>   				(int)(comma - start), start);
>   		start = comma + 1;
>   	}
> 

Why did you resend the patch?
Junio C Hamano June 15, 2021, 3:55 a.m. UTC | #2
Alex Henrie <alexhenrie24@gmail.com> writes:

> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.

Thanks, will queue.

> ---
>  graph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
>  		if (!color_parse_mem(start, comma - start, color))
>  			strvec_push(colors, color);
>  		else
> -			warning(_("ignore invalid color '%.*s' in log.graphColors"),
> +			warning(_("ignored invalid color '%.*s' in log.graphColors"),
>  				(int)(comma - start), start);
>  		start = comma + 1;
>  	}
diff mbox series

Patch

diff --git a/graph.c b/graph.c
index c128ad0cce..e3828eb8f2 100644
--- a/graph.c
+++ b/graph.c
@@ -95,7 +95,7 @@  static void parse_graph_colors_config(struct strvec *colors, const char *string)
 		if (!color_parse_mem(start, comma - start, color))
 			strvec_push(colors, color);
 		else
-			warning(_("ignore invalid color '%.*s' in log.graphColors"),
+			warning(_("ignored invalid color '%.*s' in log.graphColors"),
 				(int)(comma - start), start);
 		start = comma + 1;
 	}