| Message ID | 20210826113824.50078-3-bagasdotme@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | make: install stripped Git | expand |
On Thu, Aug 26 2021, Bagas Sanjaya wrote: > The target isn't needed anymore since stripping is done in install-strip > target (in previous patch). > > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> > --- > Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Makefile b/Makefile > index b8a3a64422..027b052a0c 100644 > --- a/Makefile > +++ b/Makefile > @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell: > > shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell > > -strip: $(PROGRAMS) git$X > - $(STRIP) $(STRIP_OPTS) $^ > > ### Flags affecting all rules This doesn't remove the phony "strip" target (nor does the first patch), and in any case I think this would be more readable with the two patches squashed together. Let's remove the old target & add the new one atomically.
Bagas Sanjaya <bagasdotme@gmail.com> writes: > The target isn't needed anymore since stripping is done in install-strip > target (in previous patch). That is not a valid justification. People's automation may have been using a perfectly valid #!/bin/sh make test && make doc && make strip && make install install-doc and this patch will break them for no good reason. We need to remember that just because we (think we) came up with a better way does not necessarily mean that we can immediately force our users to adopt the new way. > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> > --- > Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Makefile b/Makefile > index b8a3a64422..027b052a0c 100644 > --- a/Makefile > +++ b/Makefile > @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell: > > shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell > > -strip: $(PROGRAMS) git$X > - $(STRIP) $(STRIP_OPTS) $^ > > ### Flags affecting all rules
diff --git a/Makefile b/Makefile index b8a3a64422..027b052a0c 100644 --- a/Makefile +++ b/Makefile @@ -2170,8 +2170,6 @@ please_set_SHELL_PATH_to_a_more_modern_shell: shell_compatibility_test: please_set_SHELL_PATH_to_a_more_modern_shell -strip: $(PROGRAMS) git$X - $(STRIP) $(STRIP_OPTS) $^ ### Flags affecting all rules
The target isn't needed anymore since stripping is done in install-strip target (in previous patch). Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> --- Makefile | 2 -- 1 file changed, 2 deletions(-)