diff mbox series

[v4,1/3] Remove unused var

Message ID 20210831131257.1631316-1-dturner@twosigma.com (mailing list archive)
State Accepted
Commit 4577d26dc0aaae3bb35c8906db96ba043716f3f7
Headers show
Series [v4,1/3] Remove unused var | expand

Commit Message

David Turner Aug. 31, 2021, 1:12 p.m. UTC
Signed-off-by: David Turner <dturner@twosigma.com>
---
 t/t4060-diff-submodule-option-diff-format.sh | 1 -
 1 file changed, 1 deletion(-)

Comments

Junio C Hamano Aug. 31, 2021, 5:16 p.m. UTC | #1
David Turner <dturner@twosigma.com> writes:

> Signed-off-by: David Turner <dturner@twosigma.com>
> ---
>  t/t4060-diff-submodule-option-diff-format.sh | 1 -
>  1 file changed, 1 deletion(-)

Of course this still makes sense ;-)

Let me retitle it to "t4060: remove unused variable" to help readers
of "git shortlog --no-merges", though, while queuing.

Other two patches looked sensible to me, but I'd welcome comments by
submodule users, of course ;-)

Thanks.

> diff --git a/t/t4060-diff-submodule-option-diff-format.sh b/t/t4060-diff-submodule-option-diff-format.sh
> index dc7b242697..69b9946931 100755
> --- a/t/t4060-diff-submodule-option-diff-format.sh
> +++ b/t/t4060-diff-submodule-option-diff-format.sh
> @@ -361,7 +361,6 @@ test_expect_success 'typechanged submodule(submodule->blob)' '
>  rm -f sm1 &&
>  test_create_repo sm1 &&
>  head6=$(add_file sm1 foo6 foo7)
> -fullhead6=$(cd sm1; git rev-parse --verify HEAD)
>  test_expect_success 'nonexistent commit' '
>  	git diff-index -p --submodule=diff HEAD >actual &&
>  	cat >expected <<-EOF &&
diff mbox series

Patch

diff --git a/t/t4060-diff-submodule-option-diff-format.sh b/t/t4060-diff-submodule-option-diff-format.sh
index dc7b242697..69b9946931 100755
--- a/t/t4060-diff-submodule-option-diff-format.sh
+++ b/t/t4060-diff-submodule-option-diff-format.sh
@@ -361,7 +361,6 @@  test_expect_success 'typechanged submodule(submodule->blob)' '
 rm -f sm1 &&
 test_create_repo sm1 &&
 head6=$(add_file sm1 foo6 foo7)
-fullhead6=$(cd sm1; git rev-parse --verify HEAD)
 test_expect_success 'nonexistent commit' '
 	git diff-index -p --submodule=diff HEAD >actual &&
 	cat >expected <<-EOF &&