| Message ID | 20210903115933.622847-1-bagasdotme@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ca0cc98e03e870f9b82b31f00b5c6ae422528e46 |
| Headers | show |
| Series | Documentation: fix default directory of git bugreport -o | expand |
While reviewing this patch, noticed the following other minor issues as well: [PATCH 1/2] bugreport: avoid duplicating options in usage() [PATCH 2/2] bugreport: slightly better memory management Maybe could we join them all in one single "papercuts" thread for easy of management? Carlo
On 04/09/21 09.12, Carlo Marcelo Arenas Belón wrote: > While reviewing this patch, noticed the following other minor issues > as well: > > [PATCH 1/2] bugreport: avoid duplicating options in usage() > [PATCH 2/2] bugreport: slightly better memory management > > Maybe could we join them all in one single "papercuts" thread for > easy of management? OK, please add [1]. [1]: https://lore.kernel.org/git/20210903115933.622847-1-bagasdotme@gmail.com/
Bagas Sanjaya <bagasdotme@gmail.com> writes: > git bugreport writes bug report to the current directory by default, > instead of repository root. > > Fix the documentation. > > Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> > --- > Documentation/git-bugreport.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Emily, ack? It seems that after we cdup to the top, we adjust either the value of -o or "" with the prefix to come up with the output location, so the default seems to be "the current" as the updated documentation says. > diff --git a/Documentation/git-bugreport.txt b/Documentation/git-bugreport.txt > index 66e88c2e31..d8817bf3ce 100644 > --- a/Documentation/git-bugreport.txt > +++ b/Documentation/git-bugreport.txt > @@ -40,8 +40,8 @@ OPTIONS > ------- > -o <path>:: > --output-directory <path>:: > - Place the resulting bug report file in `<path>` instead of the root of > - the Git repository. > + Place the resulting bug report file in `<path>` instead of the current > + directory. > > -s <format>:: > --suffix <format>:: > > base-commit: 6c40894d2466d4e7fddc047a05116aa9d14712ee
diff --git a/Documentation/git-bugreport.txt b/Documentation/git-bugreport.txt index 66e88c2e31..d8817bf3ce 100644 --- a/Documentation/git-bugreport.txt +++ b/Documentation/git-bugreport.txt @@ -40,8 +40,8 @@ OPTIONS ------- -o <path>:: --output-directory <path>:: - Place the resulting bug report file in `<path>` instead of the root of - the Git repository. + Place the resulting bug report file in `<path>` instead of the current + directory. -s <format>:: --suffix <format>::
git bugreport writes bug report to the current directory by default, instead of repository root. Fix the documentation. Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com> --- Documentation/git-bugreport.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 6c40894d2466d4e7fddc047a05116aa9d14712ee