| Message ID | 20211001013756.37586-4-davvid@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8e2af8f0db329a8c0211a309fa9cb611b6dc2517 |
| Headers | show |
| Series | difftool: dir-diff improvements and refactoring | expand |
diff --git a/builtin/difftool.c b/builtin/difftool.c index f3cd1e5b53..437474fea0 100644 --- a/builtin/difftool.c +++ b/builtin/difftool.c @@ -568,8 +568,6 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix, write_standin_files(entry, &ldir, ldir_len, &rdir, rdir_len); } - strbuf_release(&buf); - strbuf_setlen(&ldir, ldir_len); helper_argv[1] = ldir.buf; strbuf_setlen(&rdir, rdir_len);
The `buf` strbuf is reused again later in the same function, so there is no benefit to calling strbuf_release(). The subsequent usage is already using strbuf_reset() to reset the buffer, so releasing it early is only going to lead to a wasteful reallocation. Remove the early call to strbuf_release(). The same strbuf is already cleaned up in the "finish:" section so nothing is leaked, either. Signed-off-by: David Aguilar <davvid@gmail.com> --- builtin/difftool.c | 2 -- 1 file changed, 2 deletions(-)