diff mbox series

[v2,3/3] object-file.c: LLP64 compatibility, upcast unity for left shift

Message ID 20211201002902.1042-4-philipoakley@iee.email (mailing list archive)
State Accepted
Commit 26de1fc0c99026f341b8011957562991e4ea6c51
Headers show
Series Fix LLP64 `(size_t)1` compatibility VS C4334 warnings | expand

Commit Message

Philip Oakley Dec. 1, 2021, 12:29 a.m. UTC
Visual Studio reports C4334 "was 64-bit shift intended" warning because
of size miss-match.

Promote unity to the matching type to fit with the assignment.

Signed-off-by: Philip Oakley <philipoakley@iee.email>
---
 object-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/object-file.c b/object-file.c
index c3d866a287..da8821cb91 100644
--- a/object-file.c
+++ b/object-file.c
@@ -2425,7 +2425,7 @@  struct oidtree *odb_loose_cache(struct object_directory *odb,
 	struct strbuf buf = STRBUF_INIT;
 	size_t word_bits = bitsizeof(odb->loose_objects_subdir_seen[0]);
 	size_t word_index = subdir_nr / word_bits;
-	size_t mask = 1u << (subdir_nr % word_bits);
+	size_t mask = (size_t)1u << (subdir_nr % word_bits);
 	uint32_t *bitmap;
 
 	if (subdir_nr < 0 ||