diff mbox series

[01/51] test: completion add test for __git_cmd_idx

Message ID	20220830093138.1581538-2-felipe.contreras@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: Felipe Contreras <felipe.contreras@gmail.com> To: git@vger.kernel.org Cc: git-fc@googlegroups.com, Felipe Contreras <felipe.contreras@gmail.com> Subject: [PATCH 01/51] test: completion add test for __git_cmd_idx Date: Tue, 30 Aug 2022 04:30:48 -0500 Message-Id: <20220830093138.1581538-2-felipe.contreras@gmail.com> In-Reply-To: <20220830093138.1581538-1-felipe.contreras@gmail.com> References: <20220830093138.1581538-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	completion: revamp \| expand [00/51] completion: revamp [01/51] test: completion add test for __git_cmd_idx [02/51] test: add zsh completion tests [03/51] completion: fix __git_cmd_idx regression for zsh [04/51] completion: bash: trivial cleanup [05/51] completion: zsh: add higher-priority location [06/51] zsh: resolve symlink of script [07/51] zsh: simplify realpath dirname idiom [08/51] test: reset environment variables [09/51] completion: prompt: use generic colors [10/51] completion: fix for suboptions with value [11/51] completion: zsh: trivial improvement [12/51] completion: bash: do not modify COMP_WORDBREAKS [13/51] test: completion: fix currently typed words [14/51] test: completion: switch __gitcomp_nl prefix test [15/51] test: completion: add run_func() helper [16/51] completion: bash: remove non-append functionality [17/51] completion: bash: get rid of _append() functions [18/51] completion: bash: get rid of any non-append code [19/51] completion: zsh: fix options with arguments [20/51] completion: zsh: expand --git-dir file argument [21/51] completion: zsh: add support for general -C opts [22/51] completion: zsh: fix for undefined completions [23/51] completion: zsh: add support for general -c opts [24/51] completion: zsh: fix extra space on foo= [25/51] completion: zsh: add excluded options [26/51] completion: zsh: always set compset [27/51] completion: factor out check in __gitcomp [28/51] completion: simplify equal suffix check [29/51] completion: refactor __gitcomp [30/51] completion: simplify __gitcomp [31/51] completion: bash: change suffix check in __gitcomp [32/51] completion: improve __gitcomp suffix code [33/51] test: completion: add missing test [34/51] completion: bash: simplify config_variable_name [35/51] completion: bash: improve __gitcomp description [36/51] completion: add __gitcomp_opts [37/51] completion: bash: cleanup __gitcomp* invocations [38/51] completion: bash: shuffle __gitcomp functions [39/51] completion: zsh: simplify __gitcomp_direct [40/51] completion: zsh: shuffle __gitcomp* functions [41/51] completion: zsh: fix direct quoting [42/51] completion: zsh: add elements individually in __gitcomp_opts [43/51] completion: zsh: add __gitcompadd helper [44/51] completion: zsh: add correct removable suffix [45/51] completion: bash: simplify _get_comp_words_by_ref() [46/51] completion: bash: refactor _get_comp_words_by_ref() [47/51] completion: bash: cleanup _get_comp_words_by_ref() [48/51] completion: bash: trivial cleanup [49/51] completion: bash: rename _get_comp_words_by_ref() [50/51] zsh: remove version [51/51] completion: bash: trivial grammar fix

Commit Message

Felipe Contreras Aug. 30, 2022, 9:30 a.m. UTC

When __git_func_wrap was fixed to set correctly __git_cmd_idx in
cea232194d (completion: bash: fix late declaration of __git_cmd_idx,
2021-06-18) no test was added, therefore we could hit the same bug in
the future.

To ensure that doesn't happen add a test which adds an alias for 'git
add' with __git_complete, and then pretend the user typed this alias.

To make sure __git_cmd_idx is correct we add the --update option to
ensure the result of __git_find_on_cmdline (which uses __git_cmd_idx) is
correct. When __git_cmd_idx isn't correct __git_find_on_cmdline fails,
and therefore the --update option isn't interpreted correctly.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 t/t9902-completion.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff mbox series

Patch

diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
index 43de868b80..8cc30448c7 100755
--- a/t/t9902-completion.sh
+++ b/t/t9902-completion.sh
@@ -2659,4 +2659,13 @@  test_expect_success '__git_complete' '
 	test_must_fail __git_complete ga missing
 '
 
+test_expect_success '__git_complete has correct __git_cmd_idx' '
+	__git_complete ga _git_add &&
+	echo modified > file1 &&
+	touch file3 &&
+	_words=(ga --update f) _cword=2 &&
+	__git_wrap_git_add &&
+	test "${COMPREPLY[*]}" = "file1"
+'
+
 test_done