| Message ID | 20230209154417.10763-3-cheskaqiqi@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | t4113: modernize style | expand |
On Thu, Feb 9, 2023 at 10:50 AM Shuqi Liang <cheskaqiqi@gmail.com> wrote: > As Documentation/CodingGuidelines says, the shell scripts > are to use tabs for indentation, but this script > uses 4-column indent with space. Fix it in use tabs for indentation. s/in use/to use/ > Signed-off-by: Shuqi Liang <cheskaqiqi@gmail.com> The patch itself looks fine.
Hi, Eric
On Tue, Feb 14, 2023 at 7:11 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
> The patch itself looks fine.
Thank you for your recognition!
------
Thanks
Shuqi
diff --git a/t/t4113-apply-ending.sh b/t/t4113-apply-ending.sh index 41526ca805..a470c9ce7b 100755 --- a/t/t4113-apply-ending.sh +++ b/t/t4113-apply-ending.sh @@ -25,12 +25,12 @@ echo 'b' >>file echo 'c' >>file test_expect_success setup ' - git update-index --add file + git update-index --add file ' # test test_expect_success 'apply at the end' ' - test_must_fail git apply --index test-patch + test_must_fail git apply --index test-patch ' cat >test-patch <<\EOF diff a/file b/file
As Documentation/CodingGuidelines says, the shell scripts are to use tabs for indentation, but this script uses 4-column indent with space. Fix it in use tabs for indentation. Signed-off-by: Shuqi Liang <cheskaqiqi@gmail.com> --- t/t4113-apply-ending.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)