| Message ID | 20230222040745.1511205-2-18994118902@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Modernize t9700 test script | expand |
You are missing the body of the commit message. Commit message
should start with description of the existing problem in present tense,
something like:
Test scripts in file t9700-perl-git.sh are written in old style,
where the test_expect_success command and test title are written on
separate lines ...
Then changes should be described using imperative mood, as if you are
giving commands to the codebase. See section "[[describe-changes]]"
in "Documentation/SubmittingPatches" for details.
> Signed-off-by: Zhang Yi <18994118902@163.com>
> ---
> t/t9700-perl-git.sh | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh
> index b105d6d9d5..3f6396ef63 100755
> --- a/t/t9700-perl-git.sh
> +++ b/t/t9700-perl-git.sh
> @@ -13,9 +13,8 @@ skip_all_if_no_Test_More
>
> # set up test repository
>
> -test_expect_success \
> - 'set up test repository' \
> - 'echo "test file 1" > file1 &&
> +test_expect_success 'set up test repository' '
> + echo "test file 1" > file1 &&
> echo "test file 2" > file2 &&
> mkdir directory1 &&
> echo "in directory1" >> directory1/file &&
> --
there should be no whitespace after redirect operators, so:
echo "test file 1" > file1 &&
should become:
echo "test file 1" >file1 &&
Similar changes for the rest of the test script as well.
> 2.29.0-rc0
>
diff --git a/t/t9700-perl-git.sh b/t/t9700-perl-git.sh index b105d6d9d5..3f6396ef63 100755 --- a/t/t9700-perl-git.sh +++ b/t/t9700-perl-git.sh @@ -13,9 +13,8 @@ skip_all_if_no_Test_More # set up test repository -test_expect_success \ - 'set up test repository' \ - 'echo "test file 1" > file1 && +test_expect_success 'set up test repository' ' + echo "test file 1" > file1 && echo "test file 2" > file2 && mkdir directory1 && echo "in directory1" >> directory1/file &&
Signed-off-by: Zhang Yi <18994118902@163.com> --- t/t9700-perl-git.sh | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)