[2/2] fetch: add support for HEAD update on mirrors

Commit Message

Felipe Contreras April 5, 2023, 1:27 a.m. UTC

Signed-off-by: Felipe Contreras <[e-mail]>
---
 builtin/fetch.c  | 15 ++++++++++-----
 t/t5510-fetch.sh | 18 ++++++++++++++++++
 2 files changed, 28 insertions(+), 5 deletions(-)

Patch

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 7e93a1aa46..6bf147b012 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1593,12 +1593,17 @@  static void update_head(int config, const struct ref *head, const struct remote
 	if (!head || !head->symref || !remote)
 		return;
 
-	ref = apply_refspecs((struct refspec *)&remote->fetch, "refs/heads/HEAD");
-	target = apply_refspecs((struct refspec *)&remote->fetch, head->symref);
+	if (!remote->mirror) {
+		ref = apply_refspecs((struct refspec *)&remote->fetch, "refs/heads/HEAD");
+		target = apply_refspecs((struct refspec *)&remote->fetch, head->symref);
 
-	if (!ref || !target) {
-		warning(_("could not update remote head"));
-		return;
+		if (!ref || !target) {
+			warning(_("could not update remote head"));
+			return;
+		}
+	} else {
+		ref = "HEAD";
+		target = head->symref;
 	}
 
 	r = resolve_ref_unsafe(ref, 0, NULL, &flags);
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index dbeb2928ae..d3f3b24378 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -845,6 +845,24 @@  test_expect_success 'updatehead' '
 	)
 '
 
+test_expect_success 'updatehead mirror' '
+	test_when_finished "rm -rf updatehead" &&
+
+	git clone --mirror . updatehead &&
+	(
+		cd updatehead &&
+
+		git config fetch.updateHead missing &&
+		git symbolic-ref HEAD refs/heads/side &&
+		git fetch &&
+		test_cmp_symbolic_ref HEAD refs/heads/side &&
+
+		git config fetch.updateHead always &&
+		git fetch &&
+		test_cmp_symbolic_ref HEAD refs/heads/main
+	)
+'
+
 # configured prune tests
 
 set_config_tristate () {