[v2,04/15] version-gen: simplify v prefix removal

Message ID	20230424165041.25180-5-felipe.contreras@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@vger.kernel.org> From: Felipe Contreras <felipe.contreras@gmail.com> To: git@vger.kernel.org Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>, Todd Zullinger <tmz@pobox.com>, Felipe Contreras <felipe.contreras@gmail.com> Subject: [PATCH v2 04/15] version-gen: simplify v prefix removal Date: Mon, 24 Apr 2023 10:50:30 -0600 Message-Id: <20230424165041.25180-5-felipe.contreras@gmail.com> In-Reply-To: <20230424165041.25180-1-felipe.contreras@gmail.com> References: <20230424165041.25180-1-felipe.contreras@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[v2,01/15] version-gen: reorganize \| expand [v2,01/15] version-gen: reorganize [v2,02/15] version-gen: trivial cleanup [v2,03/15] version-gen: refactor default version [v2,04/15] version-gen: simplify v prefix removal [v2,05/15] version-gen: simplify update check [v2,06/15] version-gen: simplify `git describe` checks [v2,07/15] version-gen: simplify dirty check [v2,08/15] version-gen: move describe fix into function [v2,09/15] version-gen: describe and sed in one go [v2,10/15] version-gen: refactor describe function [v2,11/15] version-gen: do v fix only when necessary [v2,12/15] version-gen: move v fix into sed [v2,13/15] version-gen: refactor main functionality [v2,14/15] version-gen: refactor GIT_VERSION string [v2,15/15] version-gen: get rid of GVF variable

Message ID

20230424165041.25180-5-felipe.contreras@gmail.com (mailing list archive)

State

New, archived

Headers

From: Felipe Contreras <felipe.contreras@gmail.com>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
        Todd Zullinger <tmz@pobox.com>,
        Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH v2 04/15] version-gen: simplify v prefix removal
Date: Mon, 24 Apr 2023 10:50:30 -0600
Message-Id: <20230424165041.25180-5-felipe.contreras@gmail.com>
In-Reply-To: <20230424165041.25180-1-felipe.contreras@gmail.com>
References: <20230424165041.25180-1-felipe.contreras@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

[v2,01/15] version-gen: reorganize | expand

Commit Message

Felipe Contreras April 24, 2023, 4:50 p.m. UTC

There is a much simpler way.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 GIT-VERSION-GEN | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index 0d00fa3d9a..c0f6bb242f 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -33,7 +33,7 @@  fi
 
 : "${VN:=$DEF_VER}"
 
-VN=$(expr "$VN" : 'v*\(.*\)')
+VN=${VN#v}
 
 if test -r $GVF
 then

[v2,04/15] version-gen: simplify v prefix removal

Commit Message

Patch