diff mbox series

[5/6] strbuf: clarify dependency

Message ID 20230502211454.1673000-6-calvinwan@google.com (mailing list archive)
State Superseded
Headers show
Series strbuf cleanups | expand

Commit Message

Calvin Wan May 2, 2023, 9:14 p.m. UTC 
Signed-off-by: Calvin Wan <calvinwan@google.com>
---
 strbuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Elijah Newren May 3, 2023, 1:56 a.m. UTC | #1 
On Tue, May 2, 2023 at 2:15 PM Calvin Wan <calvinwan@google.com> wrote:
>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> ---
>  strbuf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/strbuf.c b/strbuf.c
> index 178d75f250..d5978fee4e 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -3,7 +3,7 @@
>  #include "environment.h"
>  #include "gettext.h"
>  #include "hex.h"
> -#include "refs.h"
> +#include "strbuf.h"
>  #include "string-list.h"
>  #include "utf8.h"
>  #include "date.h"
> --
> 2.40.1.495.gc816e09b53d-goog

The commit message feels misleading.  A little digging shows that
refs.h was once upon a time needed, but no longer was as of
6bab74e7fb8 ("strbuf: move strbuf_branchname to sha1_name.c",
2010-11-06).  So, you're removing an unnecessary include, but adding
one back that was missing.  I guess that might count as "clarifying",
but maybe some of that extra context in the commit message would be
useful?
diff mbox series

Patch

diff --git a/strbuf.c b/strbuf.c
index 178d75f250..d5978fee4e 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -3,7 +3,7 @@ 
 #include "environment.h"
 #include "gettext.h"
 #include "hex.h"
-#include "refs.h"
+#include "strbuf.h"
 #include "string-list.h"
 #include "utf8.h"
 #include "date.h"