| Message ID | 20230809171531.2564754-1-oswald.buddenhagen@gmx.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b3dcd24b8a186093cd821697b191080b8d53915b |
| Headers | show |
| Series | t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1 | expand |
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes: > This was added by 3ece9bf0f9 (send-email: clear the $message_id after > validation, 2023-05-17) for no apparent reason, as this is required only > in cases when git's stdin is (must be) redirected, which isn't the case > here. > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> Good eyes. Thanks, will apply. > > --- > Cc: Junio C Hamano <gitster@pobox.com> > --- > t/t9001-send-email.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index 48bf0af2ee..c445859f73 100755 > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' ' > clean_fake_sendmail && > echo true | write_script my-hooks/sendemail-validate && > test_config core.hooksPath my-hooks && > - GIT_SEND_EMAIL_NOTTY=1 \ > git send-email --validate --to=recipient@example.com \ > --smtp-server="$(pwd)/fake.sendmail" \ > $patches $threaded_patches &&
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index 48bf0af2ee..c445859f73 100755 --- a/t/t9001-send-email.sh +++ b/t/t9001-send-email.sh @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' ' clean_fake_sendmail && echo true | write_script my-hooks/sendemail-validate && test_config core.hooksPath my-hooks && - GIT_SEND_EMAIL_NOTTY=1 \ git send-email --validate --to=recipient@example.com \ --smtp-server="$(pwd)/fake.sendmail" \ $patches $threaded_patches &&
This was added by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17) for no apparent reason, as this is required only in cases when git's stdin is (must be) redirected, which isn't the case here. Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de> --- Cc: Junio C Hamano <gitster@pobox.com> --- t/t9001-send-email.sh | 1 - 1 file changed, 1 deletion(-)