diff mbox series

[13/22] add-interactive: mark unused callback parameters

Message ID	20230828214802.GM3831137@coredump.intra.peff.net (mailing list archive)
State	Accepted
Commit	57dbb70cd953c39c9eb8a8d0fe42e5319194fb81
Headers	show Return-Path: <git-owner@vger.kernel.org> Date: Mon, 28 Aug 2023 17:48:02 -0400 From: Jeff King <peff@peff.net> To: git@vger.kernel.org Subject: [PATCH 13/22] add-interactive: mark unused callback parameters Message-ID: <20230828214802.GM3831137@coredump.intra.peff.net> References: <20230828214604.GA3830831@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230828214604.GA3830831@coredump.intra.peff.net> Precedence: bulk
Series	YAUPS: Yet Another Unused Parameter Series \| expand [0/22] YAUPS: Yet Another Unused Parameter Series [01/22] sequencer: use repository parameter in short_commit_name() [02/22] sequencer: mark repository argument as unused [03/22] ref-filter: mark unused parameters in parser callbacks [04/22] pack-bitmap: mark unused parameters in show_object callback [05/22] worktree: mark unused parameters in each_ref_fn callback [06/22] commit-graph: mark unused data parameters in generation callbacks [07/22] ls-tree: mark unused parameter in callback [08/22] stash: mark unused parameter in diff callback [09/22] trace2: mark unused us_elapsed_absolute parameters [10/22] trace2: mark unused config callback parameter [11/22] test-trace2: mark unused argv/argc parameters [12/22] grep: mark unused parameter in output function [13/22] add-interactive: mark unused callback parameters [14/22] negotiator/noop: mark unused callback parameters [15/22] worktree: mark unused parameters in noop repair callback [16/22] imap-send: mark unused parameters with NO_OPENSSL [17/22] grep: mark unused parmaeters in pcre fallbacks [18/22] credential: mark unused parameter in urlmatch callback [19/22] fetch: mark unused parameter in ref_transaction callback [20/22] bundle-uri: mark unused parameters in callbacks [21/22] gc: mark unused descriptors in scheduler callbacks [22/22] update-ref: mark unused parameter in parser callbacks

Commit Message

Jeff King Aug. 28, 2023, 9:48 p.m. UTC

The interactive commands are dispatched from a table of abstract
pointers, but not every command uses every parameter it receives. Mark
the unused ones to silence -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
---
 add-interactive.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/add-interactive.c b/add-interactive.c
index add9a1ad43..852e8e6b2f 100644
--- a/add-interactive.c
+++ b/add-interactive.c
@@ -1021,9 +1021,9 @@  static int run_diff(struct add_i_state *s, const struct pathspec *ps,
 	return res;
 }
 
-static int run_help(struct add_i_state *s, const struct pathspec *unused_ps,
-		    struct prefix_item_list *unused_files,
-		    struct list_and_choose_options *unused_opts)
+static int run_help(struct add_i_state *s, const struct pathspec *ps UNUSED,
+		    struct prefix_item_list *files UNUSED,
+		    struct list_and_choose_options *opts UNUSED)
 {
 	color_fprintf_ln(stdout, s->help_color, "status        - %s",
 			 _("show paths with changes"));
@@ -1074,7 +1074,7 @@  struct print_command_item_data {
 	const char *color, *reset;
 };
 
-static void print_command_item(int i, int selected,
+static void print_command_item(int i, int selected UNUSED,
 			       struct string_list_item *item,
 			       void *print_command_item_data)
 {